Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autofill using Spin Browser package name instead of URL #2848

Open
1 task
theRealPadster opened this issue Nov 1, 2023 · 4 comments · May be fixed by #2942
Open
1 task

Autofill using Spin Browser package name instead of URL #2848

theRealPadster opened this issue Nov 1, 2023 · 4 comments · May be fixed by #2942
Labels
bug

Comments

@theRealPadster
Copy link

theRealPadster commented Nov 1, 2023 •
edited

Steps To Reproduce

Open Spin Browser (https://play.google.com/store/apps/details?id=com.nationaledtech.spinbrowser)

  1. Go to any website and log in.
  2. Bitwarden Autofill notification appears.
  3. Select the notification.
  4. It shows com.nationaledtech.spinbrowser instead of website URL.

Expected Result

The site URL should show in the bitwarden app that pops up, and it should show matching items from my vault.

Actual Result

It shows "com.nationaledtech.spinbrowser" as the filter/search instead, and doesn't find any matching items.

Screenshots or Videos

Screenshot_20231031-233032

Additional Context

This has been happening for a year or two at least, since I started using the browser. It had the same issue on the Pixel 2 (Android 11 I think?) and Samsung Galaxy A13 5G (Android 13) phones I have used. This seems to be the same issue as #2624 and #2528. There looks to be an open PR (#2466) to fix the issue with Lemur Beta, and if it's correct, then I can make a matching PR myself for Spin Browser.

Operating System

Android

Operating System Version

14

Device

Pixel 7a

Build Version

Version: 2023.9.2 (8002)

Beta

  • Using a pre-release version of the application.
@Greenderella
Copy link
Member

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@theRealPadster
Copy link
Author

@Greenderella Thanks for taking a look! I am wondering what needs to be done to get this patched in. The PR I linked for Lemur Browser (#2466) looks like it makes some fairly simple changes to a few files to whitelist the browser package name essentially. Is that all that needs to be done? If that's the case, then I can make a similar PR for Spin Browser as well. I'm just hoping to expedite it as much as I can since it's fairly annoying always having to do a search for the site I'm on whenever I go to autofill.

@theRealPadster theRealPadster linked a pull request Jan 17, 2024 that will close this issue
Open
5 tasks
@theRealPadster
Copy link
Author

@Greenderella Just for visibility, I've created a PR that should add support, based on the recently-merged PR for Chromite #2466. If you could take a look or flag to the engineering team (or whatever the next steps would be), that would be much appreciated :)

@djsmith85 djsmith85 linked a pull request Jan 17, 2024 that will close this issue
[PM-5760] Add autofill support for Spin Browser #2942
Open
5 tasks
@Greenderella
Copy link
Member

Thank you @theRealPadster, I can see one of our engineers already linked the PR with this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PM-5760] Add autofill support for Spin Browser theRealPadster/bitwarden-mobile
2 participants
@theRealPadster @Greenderella