Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser extension: Vault export adds additional quote symbol in password #9124

Open
1 task done
keteague opened this issue May 10, 2024 · 6 comments
Open
1 task done
Labels
browser Browser Extension bug

Comments

@keteague
Copy link

keteague commented May 10, 2024

Steps To Reproduce

  1. In the Chrome extension
  2. Settings > Export vault > CSV format
  3. Settings > Export vault > .json format
  4. Copy the password from the BitWarden extension for Chrome and Firefox into a text editor
  5. Open the exported CSV file, locate the password entry, and copy it from the export file to the other text editor for a top/bottom comparison. Here, we see the exported password is 1 character longer than the (correct) password that's still in the BitWarden vault, and we see an extra quotation mark added.
  6. Open the exported JSON file, locate the password, and copy it to the other text editor for a top/bottom comparison - there is not an extra quotation mark, but there is an added backslash symbol.
  7. Repeat all of the above steps with the Firefox extension and get the same result.

Expected Result

Original/correct password that is in the Bitwarden vault
n3:X]c}~(bq5ng{jprd=E6.hS+9Y?_Ask/x@gRu,)y4Jfq}%#B?Yrt&Z9yX(,d6gKM_3h4FPLV[p5D;.Cbzu7"/^8+@c

Actual Result

Oddly enough, I can't post my result here because GitHub's parser is jacking it up, too. You can view the original (correct) and exported results here: https://text.is/0N60

Screenshots or Videos

No response

Additional Context

  • I submitted this problem yesterday with insufficient data and passed it off as a problem with viewing the exported CSV file in LibreOffice Calc. Today, I have more data to submit this as a bug report.
  • Tested this in both Chrome 124.0.6367.118 (Official Build) (64-bit) and Firefox 115.8.0esr (64-bit)
  • Reviewing my JSON export for other passwords, I have one other password that contains quotation marks separated far apart from each other, and each of them are prefixed with a \ symbol, while the original/correct password in the vault does not have them.
  • It seems there's a problem with handling the export of passwords that contains quotation marks.

Operating System

Linux

Operating System Version

Debian GNU/Linux

Web Browser

Chrome

Browser Version

124.0.6367.118

Build Version

(Official Build) (64-bit)

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@keteague keteague added browser Browser Extension bug labels May 10, 2024
@Krychaz
Copy link
Member

Krychaz commented May 10, 2024

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!

@ev4x
Copy link

ev4x commented May 29, 2024

I just want to add to this issue it also regarding the export from the web vault so not only the browser plugins and it does not happen with every password which contains " in it.

@keteague
Copy link
Author

keteague commented May 30, 2024 via email

@ev4x
Copy link

ev4x commented May 30, 2024

I found it in one which contained q"+ in the json it was q"\+ but the \ is not in every password which has the the " character even if Bitwarden interpret it right i think this makes issues with compatibility and readability.

@keteague
Copy link
Author

keteague commented May 30, 2024 via email

@keteague
Copy link
Author

keteague commented May 31, 2024

I exported my vault in CSV format using the BitWarden app from the Apple App Store and it doesn't contain any additional characters in the two examples that I posted previously. The exported passwords appear to be exactly the same as what is currently in my vault.

App version: 2024.5.0 (24604)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

3 participants