Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize that Node is out of sync and throw corresponding error #35

Open
sschiessl-bcp opened this issue Dec 4, 2018 · 3 comments
Open

Comments

@sschiessl-bcp
Copy link
Contributor

If a node is out of sync, user still sees the "Sync clock" issue. Also include the chain head block and time in the thrown error.

if (delta < 60) {

@M-Zeeshan-Haider
Copy link

also having same issues

@abitmore
Copy link
Member

abitmore commented Jan 9, 2019

The thing is, when head block time of a node is some behind your local clock, it's possible that the node is out of sync, it's also possible that your local clock is too fast, even both. How the lib would know which one is wrong if there is no more info?

I just got an idea: the API server also returns server time E.G. via HTTP response header, perhaps we can use it to check what's the real reason.

@sschiessl-bcp
Copy link
Contributor Author

How the lib would know which one is wrong if there is no more info?

Good point, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants