-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suez serialization support #123
Comments
Look good? |
Easy test: can you broadcast? :) |
I don't think so. A A |
I think we need to define a new type
and define
See bitsharesjs/lib/serializer/src/operations.js Line 1141 in e262273
|
Update:
Note that |
Cool, so I've thrown together my initial implementation in the bts-buntime repo, the code should be compatible. https://github.com/BTS-CM/bts-buntime/blob/main/src/serializer/src/operations.js New operation fee parameter entries lines 531-548: fee_parameters updated (lines 626-628): new static variant action (lines 698-706): Updated limit_order_create: Added liquidity_pool_update, credit_deal_update and limit_order_update (lines 1612 - 1639): Updated operations: Looking good? |
Created the following bitsharesjs PR: #125 |
merged for integration testing |
creates the following BEET request JSON:
Which produces the following error:
This is also the case with a testnet account. Is this wrong?
Or is it just the new bitsharesjs serialization code we've got an issue with? |
If I do:
Then beet shows:
And then trying this doesn't work neither:
It causes the beet api to throw this error:
|
@grctest the error usually means there is a serialization issue. However, the code looks OK. Maybe the extra commas at the end of each class caused the problem? I noticed that there was no comma there. To debug, please print out the serialization result (the binary form) of the transaction, and compare it with the result of |
Oh wait, it looks like the |
Should be fixed by #126 . |
Alright, I've successfully broadcast a limit order with OSO enabled:
Still need to test out the limit order update (with/without OSO); need to create an astro page to support this. |
For limit_order_update, the field Should have the limit order update astro ui page completed within the next day or so, with the above info provided :) |
Right. |
I'm encountering this issue when I try to update a limit order:
|
It looks like you need to replace
in your transaction with
Should be fixed by #128. By the way, it looks like the error message was not for the transaction you sent, because the amounts and asset IDs don't match. |
Applied the same changes to bts-buntime package too, with your fix it now broadcasts the limit order update operation successfully: https://blocksights.info/#/operations/1.11.1294152022
Yeah, I don't understand where the error about committee approval came from, sorted now at least 👍 |
Bitsharesjs currently doesn't yet support the OSO extension serialization yet
https://github.com/bitshares/bitsharesjs/blob/master/lib/serializer/src/operations.js#L621
It also doesn't yet serialize the limit order update operation neither.
The text was updated successfully, but these errors were encountered: