Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] Adapt scripts to proxy related changes in Keycloak 24 #65190

Open
dalbani opened this issue Apr 15, 2024 · 1 comment
Open
Assignees
Labels
feature-request keycloak on-hold Issues or Pull Requests with this label will never be considered stale

Comments

@dalbani
Copy link
Contributor

dalbani commented Apr 15, 2024

Name and Version

bitnami/keycloak:24

What is the problem this feature will solve?

Keycloak 24 introduces changes when it comes to proxy configuration.
See in particular:

How to reproduce:

  1. Run Docker container with KEYCLOAK_PROXY=edge for example.
  2. See the following warning in the container logs:
    WARN  [org.keycloak.quarkus.runtime.cli.Picocli] (main) The following used options or option values are DEPRECATED and will be removed in a future release:
    - proxy: Use proxy-headers.
    

What is the feature you are proposing to solve the problem?

This Docker image should probably swap the KEYCLOAK_PROXY environment variable for a new one called KEYCLOAK_PROXY_HEADERS, mapping to the proxy-headers setting in Keycloak.

Note: this change will affect the Keycloak chart at https://github.com/bitnami/charts/tree/main/bitnami/keycloak.

What alternatives have you considered?

Not really an "alternative", but in the meantime, I used KEYCLOAK_EXTRA_ARGS: --proxy-headers xforwarded to run Keycloak 24 (on Kubernetes).

@github-actions github-actions bot added the triage Triage is needed label Apr 15, 2024
@github-actions github-actions bot removed the triage Triage is needed label Apr 18, 2024
@github-actions github-actions bot assigned jotamartos and unassigned javsalgar Apr 18, 2024
@jotamartos
Copy link
Contributor

Hi @dalbani,

Thanks for taking the time to create this ticket and report this change. I just created a ticket on our side to take care of the changes. However, I can't provide you with an ETA on when this change will be ready. We will notify you when having more information.

Thanks

@jotamartos jotamartos added the on-hold Issues or Pull Requests with this label will never be considered stale label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request keycloak on-hold Issues or Pull Requests with this label will never be considered stale
Projects
None yet
Development

No branches or pull requests

3 participants