Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] Migration to Kafka 3.5 dropped support for rack awareness #25645

Open
rubenvw-ngdata opened this issue May 8, 2024 · 2 comments · May be fixed by #26296
Open

[bitnami/kafka] Migration to Kafka 3.5 dropped support for rack awareness #25645

rubenvw-ngdata opened this issue May 8, 2024 · 2 comments · May be fixed by #26296
Assignees
Labels
in-progress kafka tech-issues The user has a technical issue about an application

Comments

@rubenvw-ngdata
Copy link

Name and Version

bitnami/kafka 28.1.1

What architecture are you using?

None

What steps will reproduce the bug?

Support for kafka rack awareness was added in #13308, but dropped in #17507. I believe this was unintentional since I cannot find anything mentioning this in the commit message.

The property broker.rack is not a property that can simply be filled via extraConfig because it requires a dynamic value setting, that depends on the availability zone where the pod is scheduled.

Are you using any custom parameters or values?

No response

What is the expected behavior?

Can you add support for this unintentional removal of functionality.

The previous bitnami/kafka chart version that we used supporting this functionality was 22.0.1

What do you see instead?

No support via any of the chart parameters.

Additional information

No response

@rubenvw-ngdata rubenvw-ngdata added the tech-issues The user has a technical issue about an application label May 8, 2024
@github-actions github-actions bot added the triage Triage is needed label May 8, 2024
@rubenvw-ngdata rubenvw-ngdata changed the title Migration to Kafka 3.5 dropped support for rack awareness [bitnami/kafka] Migration to Kafka 3.5 dropped support for rack awareness May 8, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 9, 2024
@github-actions github-actions bot assigned dgomezleon and unassigned javsalgar May 9, 2024
@javsalgar javsalgar assigned migruiz4 and unassigned dgomezleon May 9, 2024
@janvanbesien-ngdata
Copy link

As @rubenvw-ngdata says, this was dropped in #17507. To be even more specific, here: https://github.com/bitnami/charts/pull/17507/files#r1594006644

@migruiz4 migruiz4 linked a pull request May 21, 2024 that will close this issue
4 tasks
@migruiz4
Copy link
Member

Hi there, as mentioned, the value brokerRackAssignment was removed during the Kafka chart major refactor.

During the chart major, we introduced several changes, such as better support for KRaft architecture, improved security standards with the introduction of the readOnlyRootFilesystem=true, as well as change how the deployment is configure, relying on mounted configuration and init container logic instead of container-specific configurations.

In addition to those changes, we removed many custom values in favor of the general common values, such as extraEnvVars, extraInitContainers, extraConfig, etc.

I may have accidentally removed this value, I didn't notice it relied on running curl in runtime, therefore it could not be replaced by extraConfig.

I have submitted #26296 restoring the missing feature, sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress kafka tech-issues The user has a technical issue about an application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants