Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeaweedFS: Support other filer-storages then MariaDB #25642

Open
gtudan opened this issue May 8, 2024 · 1 comment · May be fixed by #26366
Open

SeaweedFS: Support other filer-storages then MariaDB #25642

gtudan opened this issue May 8, 2024 · 1 comment · May be fixed by #26366
Assignees
Labels
in-progress seaweedfs tech-issues The user has a technical issue about an application

Comments

@gtudan
Copy link

gtudan commented May 8, 2024

Name and Version

bitnami/seaweedfs 0.1.4

What architecture are you using?

amd64

What steps will reproduce the bug?

  • configure the chart with mariaDB.enabled: false
  • configure an alternative storage using filer.config

Are you using any custom parameters or values?

  mariadb:
    enabled: false

  filer:
    config: |
      [redis2]
      enabled = true
      address = "redis:6379"

What is the expected behavior?

It launches the filer and uses the configured persistence

What do you see instead?

It will still launch the wait-for-db as init-container that tries to connect to the mariadb.
This container should only start if mariaDb is enabled (either via the chart, or an external db)

@gtudan gtudan added the tech-issues The user has a technical issue about an application label May 8, 2024
@gtudan gtudan changed the title Support other filer-storages then MariaDB SeaweedFS: Support other filer-storages then MariaDB May 8, 2024
@github-actions github-actions bot added the triage Triage is needed label May 8, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 13, 2024
@carrodher carrodher assigned juan131 and unassigned dgomezleon May 13, 2024
@juan131
Copy link
Contributor

juan131 commented May 14, 2024

Hi @gtudan

As you pointed out, this chart only supports MariaDB (or MySQL) as database for Filer (using the one installed via MariaDB sub-chart or fulfilling the externalDatabase.* parameters). Having said that, several stores could be potentially supported (MongoDB, Redis, Cassandra, PostgreSQL, Etcd, ...), see:

We could introduce a new externalDatabase.enabled parameter (set to false by default). This way, it would be possible to set bot mariadb.enabled and externalDatabase.enabled to false and the chart, in this case, should skip the "wait-for-db" init-container & avoid setting all the WEED_MYSQL_* env vars (see https://github.com/bitnami/charts/blob/main/bitnami/seaweedfs/templates/filer/statefulset.yaml#L138-L160)

We welcome you to create a pull request with such a contribution. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

@aodren aodren linked a pull request May 23, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress seaweedfs tech-issues The user has a technical issue about an application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants