Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/metallb] speaker/rbac.yaml contains a syntax error, fails validation #25577

Closed
oranenj opened this issue May 7, 2024 · 2 comments · Fixed by #25699
Closed

[bitnami/metallb] speaker/rbac.yaml contains a syntax error, fails validation #25577

oranenj opened this issue May 7, 2024 · 2 comments · Fixed by #25699
Assignees
Labels
metallb solved tech-issues The user has a technical issue about an application

Comments

@oranenj
Copy link

oranenj commented May 7, 2024

Name and Version

bitnami/metallb 6.1.2

What architecture are you using?

amd64

What steps will reproduce the bug?

Attempt to deploy the chart with FluxCD. It will fail. When installed manually with Helm, it won't validate the YAML, so it will succeed in installing it, but the RBAC rules are still wrong.

Are you using any custom parameters or values?

Not relevant

What is the expected behavior?

The chart should install properly

What do you see instead?

2024-05-07T13:14:51.761497741Z: preparing upgrade for metallb
2024-05-07T13:14:51.898782122Z: resetting values to the chart's original version
  Warning  UpgradeFailed  60s  helm-controller  Helm upgrade failed for release metallb-system/metallb with chart metallb@6.1.2: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
  line 23: mapping key "apiGroups" already defined at line 16
  line 25: mapping key "resources" already defined at line 18
  line 30: mapping key "verbs" already defined at line 21

Additional information

I deployed this fix locally. It appears to work.

diff --git a/bitnami/metallb/templates/speaker/rbac.yaml b/bitnami/metallb/templates/speaker/rbac.yaml
index a874767ac8..407b4a4885 100644
--- a/bitnami/metallb/templates/speaker/rbac.yaml
+++ b/bitnami/metallb/templates/speaker/rbac.yaml
@@ -23,7 +23,7 @@ rules:
       - "servicel2statuses/status"
     verbs:
       - "*"
-    apiGroups:
+  - apiGroups:
       - ''
     resources:
       - services
@oranenj oranenj added the tech-issues The user has a technical issue about an application label May 7, 2024
@github-actions github-actions bot added the triage Triage is needed label May 7, 2024
@oranenj
Copy link
Author

oranenj commented May 7, 2024

I'm not creating a PR for this since there seems to be some process involved and I don't really care that much about getting credit.

@andresbono
Copy link
Member

Thank you so much for reporting this issue. I have just created #25699 to fix the typo. This issue will be automatically closed as solevd when the PR is merged.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metallb solved tech-issues The user has a technical issue about an application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants