Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/gitea] Custom Config Value "ENABLE_OPENID_SIGNIN" #25572

Open
ikamii opened this issue May 7, 2024 · 10 comments
Open

[bitnami/gitea] Custom Config Value "ENABLE_OPENID_SIGNIN" #25572

ikamii opened this issue May 7, 2024 · 10 comments
Assignees
Labels

Comments

@ikamii
Copy link
Contributor

ikamii commented May 7, 2024

Name and Version

bitnami/gitea

What is the problem this feature will solve?

Hello, I am trying to deploy Gitea Helm chart with a custom config "ENABLE_OPENID_SIGNIN=true".

I have added

extraEnvVars:
  - name: ENABLE_OPENID_SIGNIN
    value: "true"

but it doesn't work. I couldn't find how to change it.

What is the feature you are proposing to solve the problem?

Could you maybe add this feature to change this config value. I've seen that it's not in app.ini.template.

What alternatives have you considered?

I also have tried to change the deployment.yaml but it didn't work as well.

Thank you in advance!

@github-actions github-actions bot added the triage Triage is needed label May 7, 2024
@ikamii ikamii changed the title Gitea - Custom Config Value "ENABLE_OPENID_SIGNIN" [bitnami/gitea] Custom Config Value "ENABLE_OPENID_SIGNIN" May 7, 2024
@javsalgar
Copy link
Contributor

Hi,

This may require a change in the gitea initialization logic. https://github.com/bitnami/containers/blob/main/bitnami/gitea/1/debian-12/rootfs/opt/bitnami/scripts/libgitea.sh#L189

Adding this variable and then modify the gitea configuration file. I will forward this to the team but as it is not a critical feature we cannot guarantee an ETA. If you want to speed up the process, would you like to submit a PR in bitnami/containers adding the feature?

@javsalgar javsalgar added the gitea label May 8, 2024
@ikamii
Copy link
Contributor Author

ikamii commented May 8, 2024

Hi again,

Thank you for your answer.

I would like to try to modify the gitea configuration file as well as the helm chart. If I manage to achieve it, I'll create a PR in bitnami/containers and also in bitnami/charts. Otherwise I would comment here.

Thanks!

@ikamii
Copy link
Contributor Author

ikamii commented May 8, 2024

bitnami/containers#66480

I have created a PR. I am going to update the helm chart as well.

@javsalgar
Copy link
Contributor

Thank you so much for the PR! The team will take a look

@ikamii
Copy link
Contributor Author

ikamii commented May 9, 2024

I have commented on PR after I've found an error and couldn't find any solution. You might have an idea to solve this.

After setting the values to true the container starts with the right values.

I get in app.ini

[openid]
ENABLE_OPENID_SIGNIN = true
ENABLE_OPENID_SIGNUP = true

after fully gitea initialization, both turns to false (gitea auto assigns the values to `false).

And after I restart the container it turns to the values which I set again.

@javsalgar
Copy link
Contributor

javsalgar commented May 10, 2024

Maybe these values should be set after passing the gitea wizard. There is a gitea_pass_wizard function.

@ikamii
Copy link
Contributor Author

ikamii commented May 10, 2024

The assignee of PR is also looking what is causing this issue.

I'll try what you said today 👍🏼

@ikamii
Copy link
Contributor Author

ikamii commented May 10, 2024

Hi again,

I have tried setting the values after passing the gitea wizard and it works. I will commit the changes.

@ikamii
Copy link
Contributor Author

ikamii commented May 10, 2024

I am also done with the helm chart changes. It works as good as the container. I am waiting the approval of the PR in containers. Afterwards, I'll commit the chart changes and create a PR here and close this issue.

Thanks for everything!

@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants