Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alarms to exceptions #328

Merged
merged 1 commit into from
May 21, 2024
Merged

Added alarms to exceptions #328

merged 1 commit into from
May 21, 2024

Conversation

ArnyminerZ
Copy link
Member

Purpose

See full discussion in #248, follow-up in #327

Short description

  • Added VAlarm both to the event in question and exceptions.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@ArnyminerZ
Added alarms to exceptions
5ea770a 
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ linked an issue May 16, 2024 that may be closed by this pull request
Default alert is not set for events with RECURRENCE-ID #327
Closed
@ArnyminerZ ArnyminerZ self-assigned this May 16, 2024
@ArnyminerZ ArnyminerZ mentioned this pull request May 16, 2024
Closed
@ArnyminerZ ArnyminerZ marked this pull request as ready for review May 16, 2024 15:58
@ArnyminerZ ArnyminerZ requested a review from sunkup May 16, 2024 15:58
@sunkup
Copy link
Member

sunkup commented May 17, 2024 •
edited

Maybe we should add tests? We could add a library for mocking and stubbing.

Drop the tests. Not useful for when merging with DAVx5.

@sunkup sunkup merged commit 71ab9f8 into dev May 21, 2024
7 checks passed
@sunkup sunkup deleted the 327-default-alert-is-not-set-for-events-with-recurrence-id branch May 21, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default alert is not set for events with RECURRENCE-ID
2 participants
@ArnyminerZ @sunkup