Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complementary filter potential bug Madgwick config #1319

Open
knmcguire opened this issue Sep 27, 2023 · 0 comments
Open

Complementary filter potential bug Madgwick config #1319

knmcguire opened this issue Sep 27, 2023 · 0 comments
Labels

Comments

@knmcguire
Copy link
Member

knmcguire commented Sep 27, 2023

In https://github.com/orgs/bitcraze/discussions/930, @FynZ noted that the gyroscope values were converted to degrees but there is no conversion back.

gx = gx * M_PI_F / 180;
gy = gy * M_PI_F / 180;
gz = gz * M_PI_F / 180;

This part of the code reportedly fails in a simulator and we haven't probably used this code for years, so we might need to check it out to make sure that it works.

edit: to clarify, we have Mahony as standard in kconfig but Madgwick is where this conversion happens and that one we haven't tried for a long time.

@knmcguire knmcguire added the bug label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant