Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers: Unify data structures for gains and parameters #1198

Open
knmcguire opened this issue Jan 24, 2023 · 1 comment
Open

controllers: Unify data structures for gains and parameters #1198

knmcguire opened this issue Jan 24, 2023 · 1 comment

Comments

@knmcguire
Copy link
Member

We should unify the controllers to be more similar to the recent changes to the mellinger controller as in #1180

This way we can make multiple instances of controller python bindings of at least the PID controller as well, but the PID controller code is more spread out. Perhaps we should start with a list of which files those include

@knmcguire
Copy link
Member Author

These are the three files to take into mind:

There are actually already structs for a lot of gains, but they are not written in the same way. Moreover, the gains for attitude_pid_controller are initialized in attitude_PID.c and those of position are initialized in position_controller_pid. All these gains and variables need to be initialized outside of those files, so in controller_pid, together with all the parameters that sets them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant