Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP 326 Anti Fee Sniping #1134

Open
Tracked by #80
benthecarman opened this issue Sep 28, 2023 · 4 comments · May be fixed by #1251
Open
Tracked by #80

BIP 326 Anti Fee Sniping #1134

benthecarman opened this issue Sep 28, 2023 · 4 comments · May be fixed by #1251
Assignees
@ValuedMammal
Labels
enhancement New feature or request good first issue Good for newcomers module-wallet

Comments

@benthecarman
Copy link
Contributor

Describe the enhancement

BDK currently has anti-fee sniping implemented, however it just sets the transaction locktime to the current height.

This can be improved by implementing BIP-326 which is designed to be more privacy preserving for the rest of the network, specifically for taproot transcations.

https://github.com/bitcoin/bips/blob/master/bip-0326.mediawiki
@benthecarman benthecarman added the enhancement New feature or request label Sep 28, 2023
@nondiremanuel nondiremanuel mentioned this issue Oct 6, 2023
Closed
39 tasks
@nondiremanuel nondiremanuel added the good first issue Good for newcomers label Oct 10, 2023
@nondiremanuel nondiremanuel added this to the 1.0.0-beta.0 milestone Oct 10, 2023
@notmandatory notmandatory modified the milestones: 1.0.0-beta.0, 1.0.0-alpha.4 Nov 13, 2023
@notmandatory
Copy link
Member

Since this is a functional change I moved it to the alpha.4 release. If we don't think we'll be able to implement it right now I'll move it to the 1.1 feature release.

@nondiremanuel nondiremanuel mentioned this issue Nov 19, 2023
Closed
54 tasks
@nondiremanuel nondiremanuel mentioned this issue Dec 2, 2023
Closed
55 tasks
@ValuedMammal
Copy link
Contributor

@benthecarman How does this bip326 implementation look to you so far? master...ValuedMammal:bdk:feat/bip326-afs

@benthecarman
Copy link
Contributor Author

Looking pretty good so far, you should make it a PR so people can comment on it

@ValuedMammal ValuedMammal linked a pull request Dec 30, 2023 that will close this issue
Draft
3 tasks
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@notmandatory
Copy link
Member

I propose we push to to a post 1.0 release since it's a functional improvement that shouldn't change the current wallet API.

@nondiremanuel nondiremanuel removed this from the 1.0.0-alpha milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValuedMammal ValuedMammal

Labels
enhancement New feature or request good first issue Good for newcomers module-wallet
Projects
BDK
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve fee sniping deterrence [BIP326] ValuedMammal/bdk
4 participants
@notmandatory @benthecarman @nondiremanuel @ValuedMammal