{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1181927,"defaultBranch":"master","name":"bitcoin","ownerLogin":"bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-12-19T15:16:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/528860?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713369113.0","currentOid":""},"activityList":{"items":[{"before":"0c45d73f185d0f09c9b0b5a1749f405fb8125887","after":"19865a8350a8181ab658bef48976a728bae6a8bd","ref":"refs/heads/master","pushedAt":"2024-04-29T14:38:57.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"ryanofsky","name":"Ryan Ofsky","path":"/ryanofsky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7133040?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29277: RPC: access RPC arguments by name\n\n30a6c999351041d6a1e8712a9659be1296a1b46a rpc: access some args by name (stickies-v)\nbbb31269bfa449e82d3b6a20c2c3481fb3dcc316 rpc: add named arg helper (stickies-v)\n13525e0c248eab9b199583cde76430c6da2426e2 rpc: add arg helper unit test (stickies-v)\n\nPull request description:\n\n Adds string overloads for the `RPCHelpMan::Arg` and `RPCHelpMan::MaybeArg` helpers to be able to access RPC arguments by name instead of index number. Especially in RPCs with a large number of parameters, this can be quite helpful.\n\n Example usage:\n ```cpp\n const auto action{self.Arg(\"action\")};\n ```\n\n Most of the LoC is adding test coverage and documentation updates. No behaviour change.\n\n An alternative approach to #27788 with significantly less overhaul.\n\nACKs for top commit:\n fjahr:\n Code review ACK 30a6c999351041d6a1e8712a9659be1296a1b46a\n maflcko:\n ACK 30a6c999351041d6a1e8712a9659be1296a1b46a 🥑\n ryanofsky:\n Code review ACK 30a6c999351041d6a1e8712a9659be1296a1b46a. Nice change! Implementation is surprisingly simple and additional unit test coverage is welcome, too.\n\nTree-SHA512: 4904f5f914fe1d421d32f60edb7c5a028c8ea0f140a2f207a106b4752d441164e073066a6bf2e17693f859fe847815a96609d3cf521e0ac4178d8cd09362ea3d","shortMessageHtmlLink":"Merge #29277: RPC: access RPC arguments by name"}},{"before":"4d2d91a9e0f7a0647d5a45ed04bcbf6590ce8814","after":"0c45d73f185d0f09c9b0b5a1749f405fb8125887","ref":"refs/heads/master","pushedAt":"2024-04-29T13:37:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29872: test: Add missing Assert(mock_time_in >= 0s) to SetMockTime\n\nfae0db555c12dca75fb09e5fa7bbabdf39b8c1df refactor: Use chrono type for g_mock_time (MarcoFalke)\nfa382d3dd0592f3cbd6e1de791449f49e06dae86 test: Add missing Assert(mock_time_in >= 0s) to SetMockTime (MarcoFalke)\n\nPull request description:\n\n Seems odd to have the assert in the *deprecated* function, but not in the other.\n\n Fix this by adding it to the other, and by inlining the deprecated one.\n\n Also, use chrono type for the global mocktime variable.\n\nACKs for top commit:\n davidgumberg:\n crACK https://github.com/bitcoin/bitcoin/pull/29872/commits/fae0db555c12dca75fb09e5fa7bbabdf39b8c1df\n stickies-v:\n ACK fae0db555c12dca75fb09e5fa7bbabdf39b8c1df\n\nTree-SHA512: 630c2917422ff2a7fa307114f95f22ad3c205429ffe36e67f0b2650733e40c876289c1aecebe882a9123d3106db7606bd6eff067ed6e2ecb95765984d3fe8612","shortMessageHtmlLink":"Merge #29872: test: Add missing Assert(mock_time_in >= 0s) to SetMock…"}},{"before":"a46065e36cf868265c909dc5edf29dc17be53c1f","after":"4d2d91a9e0f7a0647d5a45ed04bcbf6590ce8814","ref":"refs/heads/master","pushedAt":"2024-04-29T12:59:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29165: build: Bump clang minimum supported version to 15\n\nfa1964c5b80ee28b0e06abdbd9a26e8e8c6f5acd build: Bump clang minimum supported version to 15 (MarcoFalke)\n\nPull request description:\n\n Most supported operating systems ship with clang-15 (or later), so bump the minimum to that and allow new code to drop workarounds for previous clang bugs.\n\n For reference:\n * https://packages.debian.org/bookworm/clang-15\n * https://packages.ubuntu.com/jammy/clang-15\n * CentOS-like 8/9 Stream: All Clang versions from 15 to 17\n * FreeBSD 12/13: All Clang versions from 15 to 16\n * OpenSuse Tumbleweed ships with https://software.opensuse.org/package/clang (`clang17`); No idea about OpenSuse Leap\n\n On operating systems where the clang version is not shipped by default, the user would have to use GCC, or install clang in a different way. For example:\n\n * https://packages.debian.org/bullseye/g++ (g++-10)\n * https://packages.ubuntu.com/focal/g++-10\n * https://apt.llvm.org/, or nix, or guix, or compile clang from source, ...\n\nACKs for top commit:\n hebasto:\n ACK fa1964c5b80ee28b0e06abdbd9a26e8e8c6f5acd.\n fanquake:\n ACK fa1964c5b80ee28b0e06abdbd9a26e8e8c6f5acd - oss-fuzz LLVM will either be bumped globally tomorrow, or we'll land our own bump.\n\nTree-SHA512: b34234025b471de740480c269449891ebb95a0d9ccca67a355ff6568068bfcf1e8b104e8c13a8c0df07dbc2044dc6f03958063dc572dc4faf830bfe73466d55d","shortMessageHtmlLink":"Merge #29165: build: Bump clang minimum supported version to 15"}},{"before":"3aaf7328eb656b642e5f0f74f3e4d51645a1d0ab","after":"a46065e36cf868265c909dc5edf29dc17be53c1f","ref":"refs/heads/master","pushedAt":"2024-04-29T02:00:40.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29895: guix: remove bzip2 from deps\n\nb8e084b9781eaa4d624a3c1d58b39c07005a0e13 guix: remove no-longer-used bzip2 (fanquake)\nbd6e1d6718c8de8aa7b5bb173a201678b88d3da4 depends: switch qrencode to .tar.gz (fanquake)\n4a9b71b9006fc1d7069295c394baa74149576f2f depends: switch libxcb_util_wm to .tar.gz (fanquake)\nfad989852d4e3a0723f1f7030b21fb6ac3f8ac1d depends: switch libxcb_util_render to .tar.gz (fanquake)\nce28cb31b4ed7da9065128eb4bc9f0640e025dad depends: switch libxcb_util_keysyms to .tar.gz (fanquake)\n00a68963468cf77218bdd1158ccb9c83b5ded689 depends: switch libxcb_util_image to .tar.gz (fanquake)\n8e9190c6aae1e47f2a37d4f5f6ff4c28604e708b depends: switch libxcb_util to .tar.gz (fanquake)\nb845029d4693a0c1ed21754e15a382cd522c95a5 depends: switch xproto to .tar.gz (fanquake)\n5996c30384b0b2af1994751611cdeb81ee2a97d9 depends: switch libXau to .tar.gz (fanquake)\ne7a8dd5931c165b5aac34fcfce467bc14cd727e5 depends: switch fontconfig to .tar.gz (fanquake)\n58c423def3d71892d60b973f2d86c94de7134648 depends: switch boost to .tar.gz (fanquake)\n\nPull request description:\n\n This moves packages in depends that use `.tar.bzip2` to `.tar.gz` (which is what we use for our own release tarballs). Doing so means we can drop `bzip2` from our Guix release env. You can observe that Guix building master without it would currently fail:\n ```diff\n diff --git a/contrib/guix/manifest.scm b/contrib/guix/manifest.scm\n index 8f13c642d3..96818c7748 100644\n --- a/contrib/guix/manifest.scm\n +++ b/contrib/guix/manifest.scm\n @@ -499,7 +499,6 @@ inspecting signatures in Mach-O binaries.\")\n moreutils\n ;; Compression and archiving\n tar\n - bzip2\n gzip\n xz\n ;; Build tools\n ```\n `FORCE_DIRTY_WORKTREE=1 ./contrib/guix/guix-build`\n ```bash\n Extracting boost...\n /sources/boost_1_81_0.tar.bz2: OK\n tar (child): lbzip2: Cannot exec: No such file or directory\n tar (child): Error is not recoverable: exiting now\n tar: Child returned status 2\n tar: Error is not recoverable: exiting now\n ```\n\n Guix Build:\n ```bash\n 8f6959d01ae972bae1340dfaf18753607152eca9844e6d8c4fa128314a4ba762 guix-build-b8e084b9781e/output/aarch64-linux-gnu/SHA256SUMS.part\n 3c9c1cc000e3e6b7c2853c9d530c9afa1c880a43e7ab4c766aaa88283ff0908c guix-build-b8e084b9781e/output/aarch64-linux-gnu/bitcoin-b8e084b9781e-aarch64-linux-gnu-debug.tar.gz\n f45fbece697b450538aded11f568e92b2af391e873e113c3038d022eff41688f guix-build-b8e084b9781e/output/aarch64-linux-gnu/bitcoin-b8e084b9781e-aarch64-linux-gnu.tar.gz\n 08295d770c11b2057206f98aaf4123007c7475bd942840d048f5f9d5efec1ce1 guix-build-b8e084b9781e/output/arm-linux-gnueabihf/SHA256SUMS.part\n 0a0db6967168019b8b890ec4d31b3a87a88c4956b703938ec4447d514cfc231e guix-build-b8e084b9781e/output/arm-linux-gnueabihf/bitcoin-b8e084b9781e-arm-linux-gnueabihf-debug.tar.gz\n 3d1538e8bf4edfb66a4875198dfa90b79dcfe44eb9c4e76e47d73a18175c838a guix-build-b8e084b9781e/output/arm-linux-gnueabihf/bitcoin-b8e084b9781e-arm-linux-gnueabihf.tar.gz\n 87e7805155dbed3bd64763f199ea63843ed8c4eb37873753c7e60b0b42565eaf guix-build-b8e084b9781e/output/arm64-apple-darwin/SHA256SUMS.part\n fa33590296aeae2b738b023a4cbf2de4a4e06662a5f7d407c251a8af714bd587 guix-build-b8e084b9781e/output/arm64-apple-darwin/bitcoin-b8e084b9781e-arm64-apple-darwin-unsigned.tar.gz\n 32b8fbbdf240f9f08e44c7bb0a8ea2e8a40537e59ec2231cf6635edc6592f226 guix-build-b8e084b9781e/output/arm64-apple-darwin/bitcoin-b8e084b9781e-arm64-apple-darwin-unsigned.zip\n d176f3b7c8140c8dfde03bd87fd5abd4a89b497ba11fa6849bc92a33cb621a07 guix-build-b8e084b9781e/output/arm64-apple-darwin/bitcoin-b8e084b9781e-arm64-apple-darwin.tar.gz\n 5273b17087e3565ab042a7989cfba71cf1629331d0267137d7eccabee1a06a13 guix-build-b8e084b9781e/output/dist-archive/bitcoin-b8e084b9781e.tar.gz\n b84a9180181994a6a17a1c2a4701f8ba5a82654233d5a8afcf596d28dd8b3924 guix-build-b8e084b9781e/output/powerpc64-linux-gnu/SHA256SUMS.part\n fd3396f6b64425a31b5a3565ab4d8a1c1668c291349a0f9e9b8904dad04ee24c guix-build-b8e084b9781e/output/powerpc64-linux-gnu/bitcoin-b8e084b9781e-powerpc64-linux-gnu-debug.tar.gz\n 73cb4bd2a67934c93ea8e3f3bc04b8917627ec09d75c151bb01977bba97522c8 guix-build-b8e084b9781e/output/powerpc64-linux-gnu/bitcoin-b8e084b9781e-powerpc64-linux-gnu.tar.gz\n 15938e7f0f71303b96566d60e3b255816e7fd70d628601e592e1d6840eb8d2a1 guix-build-b8e084b9781e/output/riscv64-linux-gnu/SHA256SUMS.part\n 408b4973865e3a77be833438f71181fd88acd0490127257b3667309e8421030e guix-build-b8e084b9781e/output/riscv64-linux-gnu/bitcoin-b8e084b9781e-riscv64-linux-gnu-debug.tar.gz\n a5c02144ffb79cfa0179ff0d7ac0f81192ef1d3b1acfad334adf486e50b776bb guix-build-b8e084b9781e/output/riscv64-linux-gnu/bitcoin-b8e084b9781e-riscv64-linux-gnu.tar.gz\n de904843d8bb8601a2d763701ebb929e61b447e01040267a12149a2902489535 guix-build-b8e084b9781e/output/x86_64-apple-darwin/SHA256SUMS.part\n 414cb3cf3fa10b9a3cda47e98858222f01fdd164371dd54761642e6793099849 guix-build-b8e084b9781e/output/x86_64-apple-darwin/bitcoin-b8e084b9781e-x86_64-apple-darwin-unsigned.tar.gz\n 6ce43d7f007bf17eca16d3ee48190318e09aacd82c5396f9565e6345ec6bd2fa guix-build-b8e084b9781e/output/x86_64-apple-darwin/bitcoin-b8e084b9781e-x86_64-apple-darwin-unsigned.zip\n 24eba9c0dd1312a68c2b2a800cc915595e343c0ead982b6cbe025abe7a7bff19 guix-build-b8e084b9781e/output/x86_64-apple-darwin/bitcoin-b8e084b9781e-x86_64-apple-darwin.tar.gz\n 2869a01ce847298950a91b3b8514bc8fa39cc274a8e9cd4f68f4f038c1bb3040 guix-build-b8e084b9781e/output/x86_64-linux-gnu/SHA256SUMS.part\n 3f63e1d3b19b640d3994074b344d595bcd6fca420a1a8669b63b4ad22978308b guix-build-b8e084b9781e/output/x86_64-linux-gnu/bitcoin-b8e084b9781e-x86_64-linux-gnu-debug.tar.gz\n ccc3eb8eb56c1596981e81c8c95cadee3db799ed69b0cd1fb1e102da10adacfb guix-build-b8e084b9781e/output/x86_64-linux-gnu/bitcoin-b8e084b9781e-x86_64-linux-gnu.tar.gz\n 1ff6dab6dcde9ddbbe407cca02119c4a5d545034c91389a1c647020902b7b40e guix-build-b8e084b9781e/output/x86_64-w64-mingw32/SHA256SUMS.part\n a91c2247fd9d886e3f3ada551c0a4f9f7ffc4874e07ea5ab9de14f2743b9b8c7 guix-build-b8e084b9781e/output/x86_64-w64-mingw32/bitcoin-b8e084b9781e-win64-debug.zip\n 6fbc8d5df571fd535990370009bdfcbb37b9697c33446a08eadb1279ba6e4649 guix-build-b8e084b9781e/output/x86_64-w64-mingw32/bitcoin-b8e084b9781e-win64-setup-unsigned.exe\n 38f7a981fd2999c1e138860e1ddc183dafec090d867e37f5ab5c2d48ad4ef9ee guix-build-b8e084b9781e/output/x86_64-w64-mingw32/bitcoin-b8e084b9781e-win64-unsigned.tar.gz\n 88aca0a40a64a289617aad060a9ccf8c78bc6a201470720d8caf48d793d5207f guix-build-b8e084b9781e/output/x86_64-w64-mingw32/bitcoin-b8e084b9781e-win64.zip\n ```\n\nACKs for top commit:\n laanwj:\n This is fully expected (no weird changes from dropping bzip2 from the build env). ACK b8e084b9781eaa4d624a3c1d58b39c07005a0e13\n\nTree-SHA512: 7da9a75a3ff7fa0c9ff464e3a82f5b1d0cfdd28d5de049c910142179f7e1211c922b705361844c7029ce9baaa8e97e8016b454d2e4eee98e31fae1379674fbe2","shortMessageHtmlLink":"Merge #29895: guix: remove bzip2 from deps"}},{"before":"7fee0ca014b1513e836d2550d1b7512739d5a79a","after":"3aaf7328eb656b642e5f0f74f3e4d51645a1d0ab","ref":"refs/heads/master","pushedAt":"2024-04-28T02:55:09.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29774: build: Enable fuzz binary in MSVC\n\n18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd ci, msvc: Add \"Run fuzz binaries\" step (Hennadii Stepanov)\n52933d7283736fe3ae15e7ac44c02ca3bd95fe6d fuzz: Pass `SystemRoot` environment variable to subprocess (Hennadii Stepanov)\n23cb8207cdd6c674480840b76626039cdfe7cb13 ci, msvc: Add \"Clone fuzz corpus\" step (Hennadii Stepanov)\n19dceddf4bcdb74e84cf27229039a239b873d41b build, msvc: Build `fuzz.exe` binary (Hennadii Stepanov)\n4c078d7bd278fa8b4db6e1da7b9b747f49a8ac4c build, msvc: Enable preprocessor conformance mode (Hennadii Stepanov)\n09f5a74198c328c80539c17d951a70558e6b361e fuzz: Re-implement `read_stdin` in portable way (Hennadii Stepanov)\n\nPull request description:\n\n Closes https://github.com/bitcoin/bitcoin/issues/29760.\n\n Suggested in https://github.com/bitcoin/bitcoin/pull/29758#issuecomment-2025593572.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd 🔍\n sipsorcery:\n tACK 18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd\n sipa:\n utACK 18fd522ca9a74cf8690a6c9b9b729e78c6ed41fd\n\nTree-SHA512: 672ed6926ee9091f68f13780e77b60fc1d48731f16e847d849374f8426ffe1dafd9bcab06a27af62e8052ba345bb57f20f40579d6be8540c12ef85c23a6eec8b","shortMessageHtmlLink":"Merge #29774: build: Enable fuzz binary in MSVC"}},{"before":"1ffbd96349820cae7f076ae3253d8a9d28155fd2","after":"7fee0ca014b1513e836d2550d1b7512739d5a79a","ref":"refs/heads/master","pushedAt":"2024-04-27T06:49:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29976: build, msvc: Drop duplicated `common\\url.cpp` source file\n\n97a4ad5713853f51c729cced73f133fafa735ba2 build, msvc: Drop duplicated `common\\url.cpp` source file (Hennadii Stepanov)\n\nPull request description:\n\n After https://github.com/bitcoin/bitcoin/pull/29904, the `common\\url.cpp` source file is included into the `SOURCE_FILES` by the `msvc-autogen.py` script.\n\n Removes a compiler [warning](https://github.com/bitcoin/bitcoin/actions/runs/8853698173/job/24315127236#step:20:1776):\n ```\n url.obj : warning LNK4006: \"class std::basic_string,class std::allocator > __cdecl UrlDecode(class std::basic_string_view >)\" (?UrlDecode@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$basic_string_view@DU?$char_traits@D@std@@@2@@Z) already defined in common_url.obj; second definition ignored [D:\\a\\bitcoin\\bitcoin\\build_msvc\\libbitcoin_common\\libbitcoin_common.vcxproj]\n ```\n\nACKs for top commit:\n fanquake:\n ACK 97a4ad5713853f51c729cced73f133fafa735ba2\n\nTree-SHA512: 294955d6e6940b48a429e2302fb456706a5c62515d479398036b40716ee6b722535876adeb9b988ddb8fc942fabc39fe358c50eff0baaae92bd24bbeb4362885","shortMessageHtmlLink":"Merge #29976: build, msvc: Drop duplicated common\\url.cpp source file"}},{"before":"7973a670915632b75a6aa16f24f98b936865c48f","after":"1ffbd96349820cae7f076ae3253d8a9d28155fd2","ref":"refs/heads/master","pushedAt":"2024-04-26T20:06:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29771: test: Run framework unit tests in parallel\n\nf19f0a2e5af6c2a64900f1f229e21b6f1668bd3d test: Run framework unit tests in parallel (tdb3)\n\nPull request description:\n\n Functional test framework unit tests are currently run prior to all other functional tests.\n\n This PR enables execution of the test framework unit tests in parallel with the functional tests, rather than before the functional tests, saving runtime and more efficiently using available cores.\n\n This is a follow up to https://github.com/bitcoin/bitcoin/pull/29470#issuecomment-1962313977\n\n ### New behavior:\n 1) When running all tests, the framework unit tests are run in parallel with the other tests (unless explicitly skipped with `--exclude`). This parallelization introduces marginal time savings when running all tests, depending on the machine used. As an example, a 2-3% time savings (9 seconds) was observed on a machine using `--jobs=18` (with 18 available cores).\n 2) When running specific functional tests, framework unit tests are now skipped by default. Framework unit tests can be added by including `feature_framework_unit_tests.py` in the list of specific tests being executed. The rationale for skipping by default is that if the tester is running specific functional tests, there is a conscious decision to focus testing, and choosing to run all tests (where unit tests are run by default) would be a next step.\n 3) The `--skipunit` option is now removed since unit tests are parallelized (they no longer delay other tests). Unit tests are treated equally as functional tests.\n\n ### Implementation notes:\n Since `TextTestRunner` can be noisy (even with verbosity=0, and therefore trigger job failure through the presence of non-failure stderr output), the approach taken was to send output to stdout, and forward test result (as determined by `TestResult` returned). This aligns with the previous check for unit test failure (`if not result.wasSuccessful():`).\n\n This approach was tested by inserting `self.assertEquals(True, False)` into test_framework/address.py and seeing specifics of the failure reported.\n\n ```\n 135/302 - feature_framework_unit_tests.py failed, Duration: 0 s\n\n stdout:\n .F\n ======================================================================\n FAIL: test_bech32_decode (test_framework.address.TestFrameworkScript.test_bech32_decode)\n ----------------------------------------------------------------------\n Traceback (most recent call last):\n File \"/home/dev/myrepos/bitcoin/test/functional/test_framework/address.py\", line 228, in test_bech32_decode\n self.assertEqual(True, False)\n AssertionError: True != False\n\n ----------------------------------------------------------------------\n Ran 2 tests in 0.003s\n\n FAILED (failures=1)\n\n stderr:\n ```\n\n There was an initial thought to parallelize the execution of the unit tests themselves (i.e. run the 12 unit test files in parallel), however, this is not anticipated to further reduce runtime meaningfully and is anticipated to add unnecessary complexity.\n\nACKs for top commit:\n maflcko:\n ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d 🌽\n achow101:\n ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d\n kevkevinpal:\n Approach ACK f19f0a2e5af6c2a64900f1f229e21b6f1668bd3d\n\nTree-SHA512: ab9f82c30371b2242bc7a263ea0e25d35e68e2ddf223d2a55498ad940d1e5b73bba76cce8b264d71e2ed31b753430d8ef8d57efc1e4fd9ced7fb845e27f4f47e","shortMessageHtmlLink":"Merge #29771: test: Run framework unit tests in parallel"}},{"before":"2eff198f4900c34442439ef2cbd9d82f4903f915","after":"7973a670915632b75a6aa16f24f98b936865c48f","ref":"refs/heads/master","pushedAt":"2024-04-26T08:40:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29967: test: Add two more urlDecode tests\n\nfa55972a758865a6bd0114afe72e51877896d495 test: Add two more urlDecode tests (MarcoFalke)\n\nPull request description:\n\n Trivial follow-up after https://github.com/bitcoin/bitcoin/pull/29904#discussion_r1579216072\n\nACKs for top commit:\n laanwj:\n Code review ACK https://github.com/bitcoin/bitcoin/pull/29967/commits/fa55972a758865a6bd0114afe72e51877896d495\n fjahr:\n ACK fa55972a758865a6bd0114afe72e51877896d495\n stickies-v:\n ACK fa55972a758865a6bd0114afe72e51877896d495\n Sjors:\n utACK fa55972a758865a6bd0114afe72e51877896d495\n\nTree-SHA512: 99916feebb35b5670a365120f962fd6c28cb124635c99ac3ee3520dfc130bd1672f43b06b05b7b0b9e563d223bd009f8d6622817a2d2b4ee24596af40e2cdfaf","shortMessageHtmlLink":"Merge #29967: test: Add two more urlDecode tests"}},{"before":"0e2e7d1a355ab6d4c483e192a2f881a5beef2381","after":"2eff198f4900c34442439ef2cbd9d82f4903f915","ref":"refs/heads/master","pushedAt":"2024-04-25T20:08:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#28834: net: attempts to connect to all resolved addresses when connecting to a node\n\nfd81a37239541d0d508402cd4eeb28f38128c1f2 net: attempts to connect to all resolved addresses when connecting to a node (Sergi Delgado Segura)\n\nPull request description:\n\n This is a follow-up of #28155 motivated by https://github.com/bitcoin/bitcoin/pull/28155#discussion_r1362677038\n\n ## Rationale\n\n Prior to this, when establishing a network connection via `CConnman::ConnectNode`, if the connection needed address resolution, a single address would be picked at random from the resolved addresses and our node would try to connect to it. However, this would lead to the behavior of `ConnectNode` being unpredictable when the address was resolved to various ips (e.g. the address resolving to IPv4 and IPv6, but we only support one of them).\n\n This patches the aforementioned behavior by going over all resolved IPs until a valid one is found or until we\n exhaust them.\n\nACKs for top commit:\n mzumsande:\n re-ACK fd81a37239541d0d508402cd4eeb28f38128c1f2 (just looked at diff, only small logging change)\n achow101:\n ACK fd81a37239541d0d508402cd4eeb28f38128c1f2\n vasild:\n ACK fd81a37239541d0d508402cd4eeb28f38128c1f2\n\nTree-SHA512: fa1ebc5c84fe61dd0a7fe1113ae2d594a75ad661c43ed8984a31fc9bc50f166b2759b0d8d84ee5dc247691eff78c8156fac970af797bbcbf67492eec0353fb58","shortMessageHtmlLink":"Merge #28834: net: attempts to connect to all resolved addresses when…"}},{"before":"206629517270f6a51cd38a27552e71405b661c55","after":"0e2e7d1a355ab6d4c483e192a2f881a5beef2381","ref":"refs/heads/master","pushedAt":"2024-04-25T18:12:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29867: index: race fix, lock cs_main while 'm_synced' is subject to change\n\n65951e0418c53cbbf30b9ee85e24ccaf729088a1 index: race fix, lock cs_main while 'm_synced' is subject to change (Ryan Ofsky)\n\nPull request description:\n\n Fixes #29831 and #29863. Thanks to Marko for the detailed description of the issue.\n\n The race occurs because a block could be connected and its event signaled in-between reading the 'next block' and setting `m_synced` during the index initial synchronization. This is because `cs_main` is not locked through the process of determining the final index sync state.\n To address the issue, the `m_synced` flag set has been moved under `cs_main` guard.\n\nACKs for top commit:\n fjahr:\n Code review ACK 65951e0418c53cbbf30b9ee85e24ccaf729088a1\n achow101:\n ACK 65951e0418c53cbbf30b9ee85e24ccaf729088a1\n ryanofsky:\n Code review ACK 65951e0418c53cbbf30b9ee85e24ccaf729088a1\n\nTree-SHA512: 77286e22de164a27939d2681b7baa6552eb75e99c541d3b9631f4340d7dd01742667c86899b6987fd2d97799d959e0a913a7749b2b69d9e50505128cd3ae0e69","shortMessageHtmlLink":"Merge #29867: index: race fix, lock cs_main while 'm_synced' is subje…"}},{"before":"50b09e8173d018d63e7e3623424497953257a54a","after":"206629517270f6a51cd38a27552e71405b661c55","ref":"refs/heads/master","pushedAt":"2024-04-25T17:55:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29433: contrib: rpcauth.py - Add new option (-json) to output text in json format\n\n9adf949d2aa6d199b85295b18c08967395b5570a contrib: rpcauth.py - Add new option (-j/--json) to output text in json format (bstin)\n\nPull request description:\n\n This is a simple change to rpcauth.py utility in order to output as json instead raw text.\n\n This is beneficial because integrating json output is simpler with multiple different forms of automation and tooling\n\nACKs for top commit:\n maflcko:\n ACK 9adf949d2aa6d199b85295b18c08967395b5570a\n achow101:\n ACK 9adf949d2aa6d199b85295b18c08967395b5570a\n willcl-ark:\n tACK 9adf949d2aa6d199b85295b18c08967395b5570a\n tdb3:\n ACK for 9adf949d2aa6d199b85295b18c08967395b5570a\n\nTree-SHA512: 2cdc3b2071fbe4fb32a84ce42ee8ad216cff96ed82aaef58daeb3991953ac137ae42d6898a7fdb6cbd1800e1f61ff8d292f0b150eaebdd2a3fd9d37ed7450787","shortMessageHtmlLink":"Merge #29433: contrib: rpcauth.py - Add new option (-json) to output …"}},{"before":"3c88eac28e8984893746caebb313dc3b2fca90db","after":"50b09e8173d018d63e7e3623424497953257a54a","ref":"refs/heads/master","pushedAt":"2024-04-25T17:51:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29615: test: fix accurate multisig sigop count (BIP16), add unit test\n\n3e9c736a26724ffe3b70b387995fbf48c06300e2 test: fix accurate multisig sigop count (BIP16), add unit test (Sebastian Falbesoner)\n\nPull request description:\n\n In the course of reviewing #29589 I noticed the following buggy call-site of `CScriptOp.decode_op_n` in the CScript's `GetSigOpCount` method:\n https://github.com/bitcoin/bitcoin/blob/4cc99df44aec4d104590aee46cf18318e22a8568/test/functional/test_framework/script.py#L591-L593\n This should be `lastOpcode` rather than `opcode`. The latter is either OP_CHECKMULTISIG or OP_CHECKMULTISIGVERIFY at this point, so `decode_op_n` would result in an error. Also, in `CScript.raw_iter`, we have to return the op as `CScriptOp` type instead of a bare integer, otherwise we can't call the decode method on it. To prevent this in the future, add some simple unit tests for `GetSigOpCount`.\n\n Note that this was unnoticed, as the code part was never hit so far in the test framework.\n\nACKs for top commit:\n achow101:\n ACK 3e9c736a26724ffe3b70b387995fbf48c06300e2\n Christewart:\n ACK 3e9c736a26724ffe3b70b387995fbf48c06300e2\n rkrux:\n tACK [3e9c736](https://github.com/bitcoin/bitcoin/pull/29615/commits/3e9c736a26724ffe3b70b387995fbf48c06300e2)\n hernanmarino:\n tACK 3e9c736a26724ffe3b70b387995fbf48c06300e2\n\nTree-SHA512: 51647bb6d462fbd101effd851afdbd6ad198c0567888cd4fdcac389a9fb4bd3d7e648095c6944fd8875d36272107ebaabdc62d0e2423289055588c12294d05a7","shortMessageHtmlLink":"Merge #29615: test: fix accurate multisig sigop count (BIP16), add un…"}},{"before":"16a617461338876a03665cec7f39964602d298bb","after":"3c88eac28e8984893746caebb313dc3b2fca90db","ref":"refs/heads/master","pushedAt":"2024-04-25T17:26:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29736: test: Extends wait_for_getheaders so a specific block hash can be checked\n\nc4f857cc301d856f3c60acbe6271d3fe19441c7a test: Extends wait_for_getheaders so a specific block hash can be checked (Sergi Delgado Segura)\n\nPull request description:\n\n Fixes https://github.com/bitcoin/bitcoin/issues/18614\n\n Previously, `wait_for_getheaders` would check whether a node had received **any** getheaders message. This implied that, if a test needed to check for a specific block hash within a headers message, it had to make sure that it was checking the desired message. This normally involved having to manually clear `last_message`. This method, apart from being too verbose, was error-prone, given an undesired `getheaders` would make tests pass.\n\n This adds the ability to check for a specific block_hash within the last `getheaders` message.\n\nACKs for top commit:\n achow101:\n ACK c4f857cc301d856f3c60acbe6271d3fe19441c7a\n BrandonOdiwuor:\n crACK c4f857cc301d856f3c60acbe6271d3fe19441c7a\n cbergqvist:\n ACK c4f857cc301d856f3c60acbe6271d3fe19441c7a\n stratospher:\n tested ACK c4f857c. went through all getheaders messages sent in the tests and checked that it's the one we want.\n\nTree-SHA512: afc9a31673344dfaaefcf692ec2ab65958c3d4c005f5f3af525e9960f0622d8246d5311e59aba06cfd5c9e0ef9eb90a7fc8e210f030bfbe67b897c061efdeed1","shortMessageHtmlLink":"Merge #29736: test: Extends wait_for_getheaders so a specific block h…"}},{"before":"a9011781fc9c1a08988297bb67d1915678940fac","after":"16a617461338876a03665cec7f39964602d298bb","ref":"refs/heads/master","pushedAt":"2024-04-25T17:06:25.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"ryanofsky","name":"Ryan Ofsky","path":"/ryanofsky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7133040?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29904: refactor: Use our own implementation of urlDecode\n\n992c714451676cee33d3dff49f36329423270c1c common: Don't terminate on null character in UrlDecode (Fabian Jahr)\n099fa571511f113e0056d4bc27b3153a42f9dc65 scripted-diff: Modernize name of urlDecode function and param (Fabian Jahr)\n8f39aaae417c33490e0e41fb97620eb23ced3d05 refactor: Remove hooking code for urlDecode (Fabian Jahr)\n650d43ec15f7a3ae38126f65ef8fa0b1fd3ee936 refactor: Replace libevent use in urlDecode with our own code (Fabian Jahr)\n46bc6c2aaa613eef526b21a06bf21e8edde31a88 test: Add unit tests for urlDecode (Fabian Jahr)\n\nPull request description:\n\n Fixes #29654 (as a side-effect)\n\n Removing dependencies is a general goal of the project and the xz backdoor has been an additional wake up call recently. Libevent shows many of the same symptoms, few maintainers and slow releases. While libevent can not be removed completely over night we should start removing it’s usage where it's possible, ideally with the end goal to removing it completely.\n\n This is a pretty easy win in that direction. The [`evhttp_uridecode` function from libevent](https://github.com/libevent/libevent/blob/e0a4574ba2cbcdb64bb2b593e72be7f7f4010746/http.c#L3542) we were using in `urlDecode` could be easily emulated in fewer LOC. This also ports the [applicable test vectors over from libevent](https://github.com/libevent/libevent/blob/master/test/regress_http.c#L3430).\n\nACKs for top commit:\n achow101:\n ACK 992c714451676cee33d3dff49f36329423270c1c\n theStack:\n Code-review ACK 992c714451676cee33d3dff49f36329423270c1c\n maflcko:\n ACK 992c714451676cee33d3dff49f36329423270c1c 👈\n stickies-v:\n ACK 992c714451676cee33d3dff49f36329423270c1c\n\nTree-SHA512: 78f76ae7ab3b6710eab2aaac20f55eb0da7803e057eaa6220e865f328666a5399ef1a479702aaf630b2f974ad3aa15e2b6adac9c11bc8c3d4be21e8af1667fea","shortMessageHtmlLink":"Merge #29904: refactor: Use our own implementation of urlDecode"}},{"before":"0eb1459efa91c6a3bc2964007057cef2f7280a57","after":"a9011781fc9c1a08988297bb67d1915678940fac","ref":"refs/heads/master","pushedAt":"2024-04-25T16:34:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29689: lint: scripted-diff verification also requires GNU grep\n\n3bf4f8db669e1e274ce2633cf84add2938b9914b lint: scripted-diff verification also requires GNU grep (Sjors Provoost)\n\nPull request description:\n\n I noticed while trying to verify all historical `scripted-diff:` commits on macOS that some scripts require GNU sed.\n\n For example 0d6d2b650d1017691f48c9109a6cd020ab46aa73 uses `git grep --perl-regexp`.\n\nACKs for top commit:\n hernanmarino:\n cr ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b\n maflcko:\n utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b\n achow101:\n ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b\n alfonsoromanz:\n Tested ACK 3bf4f8db669e1e274ce2633cf84add2938b9914b\n kristapsk:\n cr utACK 3bf4f8db669e1e274ce2633cf84add2938b9914b\n\nTree-SHA512: 09a060ab1bafad03df60d0f20c3dd1451850868dbd66ea38b18178b6230c1f06cf48622db82d9c51422d5689962ee0cd7aae0a31f84bd6d878215e6d73c1d47e","shortMessageHtmlLink":"Merge #29689: lint: scripted-diff verification also requires GNU grep"}},{"before":"d48d55e0d30057c60293a5f76e312e8eda452f78","after":"0eb1459efa91c6a3bc2964007057cef2f7280a57","ref":"refs/heads/master","pushedAt":"2024-04-25T13:22:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29953: doc: Bash is needed in gen_id and is not installed on FreeBSD by default\n\n9381052194a78024b3994cc6ad906858c477b88f doc: Bash is needed in gen_id and is not installed on FreeBSD by default (Hennadii Stepanov)\n\nPull request description:\n\n On FreeBSD 14.0, in the `depends` directory:\n\n - without `bash`:\n ```\n $ gmake print-bdb_build_id_long\n env: bash: No such file or directory\n env: bash: No such file or directory\n bdb_build_id_long=bdb-4.8.30-4b0c6f8e95251b9c6731844fc34111c04b75fd9f15c671d6e34f2a4d014ec1be-release\n $ gmake print-final_build_id\n env: bash: No such file or directory\n env: bash: No such file or directory\n final_build_id=722b2d3e264\n ```\n\n - with `bash`:\n ```\n $ gmake print-bdb_build_id_long\n bdb_build_id_long=bdb-4.8.30-4b0c6f8e95251b9c6731844fc34111c04b75fd9f15c671d6e34f2a4d014ec1be-release 1ed47cefe468014c79dedb275cf921f44ab28d91dd56bf94712409b81326d765\n $ gmake print-final_build_id\n final_build_id=7b4f9aaa683\n ```\n\nACKs for top commit:\n vasild:\n ACK 9381052194a78024b3994cc6ad906858c477b88f\n kristapsk:\n ACK 9381052194a78024b3994cc6ad906858c477b88f\n alfonsoromanz:\n ACK 9381052194a78024b3994cc6ad906858c477b88f\n\nTree-SHA512: da3f3469ac416518180194f09fb054fb352a2793848fb9a7982439de08244ff6149a7f449ad21fcdf0e9bd79b6949a91751f9cc35833953d2b6a35cea5c6ae21","shortMessageHtmlLink":"Merge #29953: doc: Bash is needed in gen_id and is not installed on F…"}},{"before":"ee1c975f80a0accd991c3c9c82b7eb52a76c6d30","after":"d48d55e0d30057c60293a5f76e312e8eda452f78","ref":"refs/heads/master","pushedAt":"2024-04-25T13:21:48.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29890: deploy: remove some tools when cross-compiling for macOS\n\n1a9aa8d4eedff3788c792799328ad599132e0da1 build: better scope usage of -Wl,-headerpad_max_install_names (fanquake)\n3bee51427a05075150721f0a05ead8f92e1ba019 build: don't use install_name_tool for macOS deploy when cross-compiling (fanquake)\n78b6b5c485191b85ae201df9d5ef0bcdaaa9c190 build: don't pass strip to macOS deploy if cross-compiling (fanquake)\n\nPull request description:\n\n Neither of these tools are actually used when we are cross-compiling for macOS. They are used when we have to adjust non-static libs during a deploy after building on a macOS machine. Simplies #29739 (will be rebased on top).\n\n Guix (aarch64):\n ```bash\n 8f29bce75d7f574306a0e38d793e0e4e145b547a4b9e5a755a54976121d8ac41 guix-build-5afd3c302051/output/arm64-apple-darwin/SHA256SUMS.part\n 9ba01fe46be715adcbe80f39dc7dbe449f32ca9d9b660da698f933aef3e6d80b guix-build-5afd3c302051/output/arm64-apple-darwin/bitcoin-5afd3c302051-arm64-apple-darwin-unsigned.tar.gz\n 37719437e951449341d0e10dcc4afe93e955d59de5312ce6351e1fa01b4927ac guix-build-5afd3c302051/output/arm64-apple-darwin/bitcoin-5afd3c302051-arm64-apple-darwin-unsigned.zip\n 06a79fc871dcd4290f5f7e7e9de19a5a535203d20279f4555d1c319d07abe2d0 guix-build-5afd3c302051/output/arm64-apple-darwin/bitcoin-5afd3c302051-arm64-apple-darwin.tar.gz\n 98d2b8b37197dcad36a04eb2f3ff2130b859220a17b83a4186a78dcf0af4eafd guix-build-5afd3c302051/output/dist-archive/bitcoin-5afd3c302051.tar.gz\n df63ff44ef41565ff13ce6dde5485173a18d5866ebc316df86f9ebd91fda18f5 guix-build-5afd3c302051/output/x86_64-apple-darwin/SHA256SUMS.part\n 28362ce9e80d5e78db198efa5f89434fbe76ca91df5fde7455da4d50ceb8523a guix-build-5afd3c302051/output/x86_64-apple-darwin/bitcoin-5afd3c302051-x86_64-apple-darwin-unsigned.tar.gz\n 534745b679eb9e8e408dd251a6bf0829e62e12f7a41772b8a57a044ded14208c guix-build-5afd3c302051/output/x86_64-apple-darwin/bitcoin-5afd3c302051-x86_64-apple-darwin-unsigned.zip\n f53d0c9a1bb83d548c7d274c7d39653a3989fb1b4efec49e73dd1cac7c92074c guix-build-5afd3c302051/output/x86_64-apple-darwin/bitcoin-5afd3c302051-x86_64-apple-darwin.tar.gz\n ```\n\nACKs for top commit:\n TheCharlatan:\n ACK 1a9aa8d4eedff3788c792799328ad599132e0da1\n\nTree-SHA512: 0aa77ea4d6dc45c226806bb1758b6aa7e8ca17f91045bab4fc6891af7b9de476211cd5692c11cb9d5bcf59744fd86a2534812a77fe304ae10c3518e08fc412be","shortMessageHtmlLink":"Merge #29890: deploy: remove some tools when cross-compiling for macOS"}},{"before":"10f50220724c02efe0ba38717cc64578ffb58ebc","after":"ee1c975f80a0accd991c3c9c82b7eb52a76c6d30","ref":"refs/heads/master","pushedAt":"2024-04-25T13:13:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29938: Fix typos in description.md and wallet_util.py\n\n03e36b3da093e2c23cf51b46f6901cb84ddbf867 Fix typos in description.md and wallet_util.py (hanmz)\n\nPull request description:\n\n Fix typos in description.md.\n `digestable` => `digestible`\n `lenghts` => `lengths`\n\nACKs for top commit:\n maflcko:\n ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867\n kristapsk:\n ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867\n brunoerg:\n utACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867\n alfonsoromanz:\n ACK 03e36b3da093e2c23cf51b46f6901cb84ddbf867\n\nTree-SHA512: 592b85f92459e96d35ddb41f2913f950a2ef9b9b74ef85af03a72553893b32e76cc6630091199359140a1d403e61c7354b61f6e09fd122c7c9fb677ce4bd48d6","shortMessageHtmlLink":"Merge #29938: Fix typos in description.md and wallet_util.py"}},{"before":"2a07c4662d7266158d47f79fa2433ab22e22c907","after":"10f50220724c02efe0ba38717cc64578ffb58ebc","ref":"refs/heads/master","pushedAt":"2024-04-25T13:07:59.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29708: depends: build libnatpmp with CMake\n\n3c1ae3ee33d4d9dbea046d5ab8ee924a12982759 depends: switch libnatpmp to CMake (Cory Fields)\n72ba7b5d263b6d909ae59040536a499a596237c2 depends: libnatpmp f2433bec24ca3d3f22a8a7840728a3ac177f94ba (fanquake)\n\nPull request description:\n\n This picks up one of the changes from https://github.com/bitcoin/bitcoin/pull/29232, which is a switch to building libnatpmp with CMake. It includes an update to the most recent version of libnatpmp (https://github.com/miniupnp/libnatpmp/commit/f2433bec24ca3d3f22a8a7840728a3ac177f94ba), which includes (https://github.com/miniupnp/libnatpmp/pull/43).\n\n From an initial look I couldn't find any significant difference between the Autotools and CMake produced libs.\n\nACKs for top commit:\n m3dwards:\n ACK https://github.com/bitcoin/bitcoin/pull/29708/commits/3c1ae3ee33d4d9dbea046d5ab8ee924a12982759\n hebasto:\n ACK 3c1ae3ee33d4d9dbea046d5ab8ee924a12982759.\n TheCharlatan:\n ACK 3c1ae3ee33d4d9dbea046d5ab8ee924a12982759\n\nTree-SHA512: 1dd9d9933a5fceb9f8c4e1d68cd5cb4456a10a6dd27a6f6316f14493f9d2efad981ef8be9570c09ca82d45163aebd7f4cb2b2449989ec6084268ddba9a564c83","shortMessageHtmlLink":"Merge #29708: depends: build libnatpmp with CMake"}},{"before":"50729c060907b69543755a8e1ed6b0d32d071a8a","after":"2a07c4662d7266158d47f79fa2433ab22e22c907","ref":"refs/heads/master","pushedAt":"2024-04-24T15:52:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29757: feefrac: avoid explicitly computing diagram; compare based on chunks\n\nb22901dfa9cc3af94bf13163a28300eb1ab25b22 Avoid explicitly computing diagram; compare based on chunks (Pieter Wuille)\n\nPull request description:\n\n This merges the `BuildDiagramFromChunks` and `CompareFeeRateDiagram` introduced in #29242 into a single `CompareChunks` function, which operates on sorted chunk data rather than diagrams, instead computing the diagram on the fly.\n\n This avoids the need for the construction of an intermediary diagram object, and removes the slightly arbitrary \"all diagrams must start at (0, 0)\" requirement.\n\n Not a big deal, but I think the result is a bit cleaner and not really more complicated.\n\nACKs for top commit:\n glozow:\n reACK b22901d\n instagibbs:\n reACK https://github.com/bitcoin/bitcoin/pull/29757/commits/b22901dfa9cc3af94bf13163a28300eb1ab25b22\n\nTree-SHA512: ca37bdf61d9a9cb5435f4da73e97ead33bf65828ad9af49b87336b1ece70db8ced1c21f517fc6eb6d616311c91f3da75ecae6b9bd42547133e3a3c5320b7816d","shortMessageHtmlLink":"Merge #29757: feefrac: avoid explicitly computing diagram; compare ba…"}},{"before":"d822d4e849646a455aa360efd4a48a546ecc5950","after":"50729c060907b69543755a8e1ed6b0d32d071a8a","ref":"refs/heads/master","pushedAt":"2024-04-24T14:57:58.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29910: refactor: Rename `subprocess.hpp` to follow our header name conventions\n\n08f756bd370c3e100b186c7e24bef6a033575b29 Replace locale-dependent `std::strerror` with `SysErrorString` (Hennadii Stepanov)\nd8e4ba4d0568769782b8c19c82e955c4aee73477 refactor: Rename `subprocess.hpp` to follow our header name conventions (Hennadii Stepanov)\n\nPull request description:\n\n This PR renames the header `*.hpp` --> `*.h` and adjusts the header guard name, which makes it available for processing by linters.\n\n Fixed the following linter warning:\n ```\n The locale dependent function strerror(...) appears to be used:\n src/util/subprocess.h: std::runtime_error( err_msg + \": \" + std::strerror(err_code) )\n\n Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.\n\n Advice not applicable in this specific case? Add an exception by updating the ignore list in /bitcoin/test/lint/lint-locale-dependence.py\n ^---- failure generated from lint-locale-dependence.py\n ```\n\nACKs for top commit:\n TheCharlatan:\n ACK 08f756bd370c3e100b186c7e24bef6a033575b29\n\nTree-SHA512: 57a2f01c20eb9552481e428a4969bd59e9ada9f784fe1a45cb62aa9c9152c8e950d336854f45af0e2e5dc7c7b2a1fb216c8f832e3d6ccfb457ad71b6e423231e","shortMessageHtmlLink":"Merge #29910: refactor: Rename subprocess.hpp to follow our header …"}},{"before":"427044afa3614e3380c525140b50df48822d939f","after":"d822d4e849646a455aa360efd4a48a546ecc5950","ref":"refs/heads/master","pushedAt":"2024-04-24T14:46:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29837: ci: disable `_FORTIFY_SOURCE` with MSAN\n\n08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc ci: disable _FORTIFY_SOURCE with MSAN (fanquake)\n\nPull request description:\n\n By undefining `_FORTIFY_SOURCE` we can drop`--disable-hardening`.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc\n hernanmarino:\n utACK 08ff17d1420a3d1c14c6b1a5436678fbb1dd9cbc . Relevant CI test seems to be working OK.\n\nTree-SHA512: 948fd075aa648a7e34c37376fb913074ebc07d1c3cb0737d5fcbe7eac0b35c4152139773e4515ccb80f2d11b1ced6c6984da1757c2bcf8dd90e8ff6f664dae8e","shortMessageHtmlLink":"Merge #29837: ci: disable _FORTIFY_SOURCE with MSAN"}},{"before":"c143244ce3fbfd9776496283489832ba4737e370","after":"427044afa3614e3380c525140b50df48822d939f","ref":"refs/heads/master","pushedAt":"2024-04-24T13:24:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29585: contrib: list other binaries in manpage output\n\n7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba contrib: list other binaries in manpage output (fanquake)\n\nPull request description:\n\n Add a `SEE ALSO` section to the manpages.\n\n Master:\n ![master](https://github.com/bitcoin/bitcoin/assets/863730/da6f0151-e43a-4578-983d-4f2def80a8eb)\n\n This PR:\n ![pr](https://github.com/bitcoin/bitcoin/assets/863730/d57a1c9a-50c7-4f1a-834e-0f8af8520921)\n\n Should be enough to close #29558.\n\nACKs for top commit:\n jarolrod:\n tACK 7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba\n willcl-ark:\n ACK 7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba\n pablomartin4btc:\n utACK 7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba\n laanwj:\n Code review ACK 7c3ac598dd9a1f1a506c4931249ff6c9f1c949ba\n\nTree-SHA512: 0df13ed5d736aa514a1192115728314fc676714f4cb9131f37b5d9a9bfc8f85f98c21b859d6b62745211f3de16b33ff60888e7f6a4eca66fc0c52442503f4336","shortMessageHtmlLink":"Merge #29585: contrib: list other binaries in manpage output"}},{"before":"072b118407af08dd68a10f94190b600d63b99758","after":"c143244ce3fbfd9776496283489832ba4737e370","ref":"refs/heads/master","pushedAt":"2024-04-24T13:14:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29853: sign: don't assume we are parsing a sane TapMiniscript\n\n4d8d21320eba54571ff63931509cd515c3e20339 sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot)\n\nPull request description:\n\n The script provided for signature might be externally provided, for instance by way of 'finalizepsbt'. Therefore the script might be ill-crafted, so don't assume pubkeys are always 32 bytes.\n\n Thanks to Niklas for finding this.\n\n FIxes https://github.com/bitcoin/bitcoin/issues/29851.\n\nACKs for top commit:\n achow101:\n ACK 4d8d21320eba54571ff63931509cd515c3e20339\n furszy:\n ACK 4d8d21320eba54571ff63931509cd515c3e20339 with a small nuance that could be tackled in a follow-up by someone else (or never).\n\nTree-SHA512: 29b7948b56e6dc05eac1014d684f2129ab1d19cb1e5d304216c826b7057c0e1d84ceb18731b91124b680e17d90e38de9f9a5526e4f6ecc3ea816881a6599bb47","shortMessageHtmlLink":"Merge #29853: sign: don't assume we are parsing a sane TapMiniscript"}},{"before":"631a2b5b3f2a9db6007c5c3e74e576d34e581d54","after":"072b118407af08dd68a10f94190b600d63b99758","ref":"refs/heads/master","pushedAt":"2024-04-24T13:05:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29932: doc: suggest only necessary Qt packages for installation on FreeBSD\n\ndace02f99d4a8785567732c0d687517175765bfd doc: suggest only necessary Qt packages for installation on FreeBSD (Vasil Dimov)\n\nPull request description:\n\n The previously suggested `qt5` package is a meta package that does not\n install anything itself but depends on a bunch of others and is used as\n a convenience to install \"everything\" Qt5 related: 270 packages / 3 GiB.\n\n We only need a subset of those which amounts to 79 packages / 381 MiB,\n so suggest just that.\n\n For comparison:\n\n ```\n pkg install qt5\n Updating local repository catalogue...\n local repository is up to date.\n All repositories are up to date.\n Checking integrity... done (0 conflicting)\n The following 270 package(s) will be affected (of 0 checked):\n\n New packages to be INSTALLED:\n Imath: 3.1.11\n abseil: 20230125.3\n alsa-lib: 1.2.11\n alsa-plugins: 1.2.7.1_3\n aom: 3.8.2\n assimp: 5.4.0\n avahi-app: 0.8_2\n brotli: 1.1.0,1\n consolekit2: 1.2.6_3\n cups: 2.4.7_2\n curl: 8.7.1\n cyrus-sasl: 2.1.28_4\n dav1d: 1.4.1\n dbus: 1.14.10_5,1\n dbus-glib: 0.112_1\n dejavu: 2.37_3\n dotconf: 1.3_1\n double-conversion: 3.3.0\n duktape-lib: 2.7.0\n encodings: 1.1.0,1\n espeak-ng: 1.51.1_5\n expat: 2.6.2\n ffmpeg: 6.1.1_5,1\n fftw3: 3.3.10_5\n fftw3-float: 3.3.10_5\n flac: 1.4.3_1,1\n font-bh-ttf: 1.0.3_5\n font-misc-ethiopic: 1.0.4\n font-misc-meltho: 1.0.3_5\n fontconfig: 2.15.0_2,1\n freetds: 1.4.12,1\n freetype2: 2.13.2\n fribidi: 1.0.13_1\n gdbm: 1.23\n gdk-pixbuf2: 2.42.10_2\n gettext-runtime: 0.22.5\n giflib: 5.2.1_1\n glib: 2.80.0,2\n gmp: 6.3.0\n gnome_subr: 1.0\n gnutls: 3.8.5_1\n graphite2: 1.3.14\n groff: 1.23.0_3\n gstreamer1: 1.22.10\n gstreamer1-plugins: 1.22.10_1\n gstreamer1-plugins-bad: 1.22.10_2\n harfbuzz: 8.4.0\n hicolor-icon-theme: 0.17\n hidapi: 0.14.0\n highway: 1.1.0\n hunspell: 1.7.2_1\n icu: 74.2_1,1\n indexinfo: 0.3.1\n iso-codes: 4.15.0\n jasper: 4.2.3\n jbigkit: 2.1_2\n jpeg-turbo: 3.0.2\n jsoncpp: 1.9.5\n lame: 3.100_5\n lcms2: 2.16_1\n libICE: 1.1.0_2,1\n libSM: 1.2.3_1,1\n libX11: 1.8.9,1\n libXScrnSaver: 1.2.4_1\n libXau: 1.0.9_1\n libXcomposite: 0.4.6_1,1\n libXcursor: 1.2.2\n libXdamage: 1.1.6\n libXdmcp: 1.1.5\n libXext: 1.3.6,1\n libXfixes: 6.0.0_1\n libXi: 1.8_1,1\n libXmu: 1.1.4,1\n libXrandr: 1.5.2_1\n libXrender: 0.9.10_2\n libXt: 1.3.0,1\n libXtst: 1.2.3_3\n libXv: 1.0.12_1,1\n libass: 0.17.1_2\n libcbor: 0.11.0\n libcjson: 1.7.17\n libdaemon: 0.14_1\n libdeflate: 1.20\n libdrm: 2.4.120_1,1\n libedit: 3.1.20230828_1,1\n libepoll-shim: 0.0.20230411\n libevdev: 1.13.1\n libevent: 2.1.12\n libffi: 3.4.4_1\n libfido2: 1.14.0\n libfontenc: 1.1.8\n libgcrypt: 1.10.3_1\n libglvnd: 1.7.0\n libgpg-error: 1.48\n libgudev: 237\n libiconv: 1.17_1\n libidn2: 2.3.7\n libinput: 1.25.0\n libjxl: 0.10.2\n libltdl: 2.4.7\n liblz4: 1.9.4_1,1\n libmng: 2.0.3_1\n libmtdev: 1.1.6_1\n libmysofa: 1.3.2\n libnghttp2: 1.61.0\n libnice: 0.1.21_2\n libogg: 1.3.5,4\n libpaper: 1.1.28_1\n libpci: 3.12.0\n libpciaccess: 0.18\n libplacebo: 6.338.2\n libpsl: 0.21.5\n libsndfile: 1.2.2_1\n libsoxr: 0.1.3_3\n libssh2: 1.11.0_1,3\n libtasn1: 4.19.0_1\n libudev-devd: 0.5.2\n libunibreak: 6.1,1\n libunistring: 1.2\n libunwind: 20240221\n libv4l: 1.23.0_4\n libva: 2.21.0\n libvdpau: 1.5\n libvorbis: 1.3.7_2,3\n libvpx: 1.14.0\n libwacom: 1.5_1\n libx264: 0.164.3095\n libxcb: 1.17.0\n libxkbcommon: 1.6.0_2\n libxkbfile: 1.1.3\n libxml2: 2.11.7\n libxslt: 1.1.37_1\n llvm15: 15.0.7_10\n lua53: 5.3.6_1\n minizip: 1.2.11_1\n mkfontscale: 1.2.3\n mpdecimal: 4.0.0\n mpg123: 1.32.5\n mysql80-client: 8.0.35\n nettle: 3.9.1\n nspr: 4.35\n nss: 3.99\n openal-soft: 1.21.1_4\n openexr: 3.2.4\n openh264: 2.3.0,2\n openldap26-client: 2.6.7\n opus: 1.5.2\n orc: 0.4.36\n p11-kit: 0.25.3_2\n pcaudiolib: 1.2_1\n pciids: 20240331\n pcre2: 10.43\n perl5: 5.36.3_1\n png: 1.6.43\n polkit: 124_3\n postgresql15-client: 15.6\n psutils: 1.17_6\n pulseaudio: 16.1_4\n py39-evdev: 1.6.0\n py39-packaging: 24.0\n py39-pyudev: 0.22.0\n py39-setuptools: 63.1.0_1\n py39-six: 1.16.0\n python39: 3.9.18_2\n qt5: 5.15.13\n qt5-3d: 5.15.13p0\n qt5-assistant: 5.15.13p4\n qt5-buildtools: 5.15.13p142\n qt5-charts: 5.15.13p0\n qt5-concurrent: 5.15.13p142\n qt5-connectivity: 5.15.13p4\n qt5-core: 5.15.13p142\n qt5-datavis3d: 5.15.13p0\n qt5-dbus: 5.15.13p142\n qt5-declarative: 5.15.13p30\n qt5-declarative-test: 5.15.13p30\n qt5-designer: 5.15.13p4\n qt5-doc: 5.12.2\n qt5-examples: 5.15.13\n qt5-gamepad: 5.15.13p0\n qt5-graphicaleffects: 5.15.13p0\n qt5-gui: 5.15.13p142\n qt5-help: 5.15.13p4\n qt5-imageformats: 5.15.13p7\n qt5-l10n: 5.15.13p0\n qt5-linguist: 5.15.13p4\n qt5-linguisttools: 5.15.13p4\n qt5-location: 5.15.13p6\n qt5-multimedia: 5.15.13p2\n qt5-network: 5.15.13p142\n qt5-networkauth: 5.15.13p0\n qt5-opengl: 5.15.13p142\n qt5-pixeltool: 5.15.13p4\n qt5-printsupport: 5.15.13p142\n qt5-qdbus: 5.15.13p4\n qt5-qdbusviewer: 5.15.13p4\n qt5-qdoc: 5.15.13p4\n qt5-qdoc-data: 5.15.13\n qt5-qev: 5.15.13p4\n qt5-qmake: 5.15.13p142\n qt5-qtdiag: 5.15.13p4\n qt5-qtpaths: 5.15.13p4\n qt5-qtplugininfo: 5.15.13p4\n qt5-quick3d: 5.15.13p1\n qt5-quickcontrols: 5.15.13p0\n qt5-quickcontrols2: 5.15.13p5\n qt5-quicktimeline: 5.15.13p0\n qt5-remoteobjects: 5.15.13p0\n qt5-script: 5.15.16p0_2\n qt5-scripttools: 5.15.16p0_1\n qt5-scxml: 5.15.13p0\n qt5-sensors: 5.15.13p0\n qt5-serialbus: 5.15.13p0\n qt5-serialport: 5.15.13p0\n qt5-speech: 5.15.13p1\n qt5-sql: 5.15.13p142\n qt5-sqldrivers-mysql: 5.15.13p142\n qt5-sqldrivers-odbc: 5.15.13p142\n qt5-sqldrivers-pgsql: 5.15.13p142\n qt5-sqldrivers-sqlite2: 5.15.13p142\n qt5-sqldrivers-sqlite3: 5.15.13p142\n qt5-sqldrivers-tds: 5.15.13p142\n qt5-svg: 5.15.13p6\n qt5-testlib: 5.15.13p142\n qt5-uiplugin: 5.15.13p4\n qt5-uitools: 5.15.13p4\n qt5-virtualkeyboard: 5.15.13p0\n qt5-webchannel: 5.15.13p3\n qt5-webengine: 5.15.16.p9\n qt5-webglplugin: 5.15.13p0\n qt5-websockets: 5.15.13p2\n qt5-websockets-qml: 5.15.13p2\n qt5-webview: 5.15.13p0\n qt5-widgets: 5.15.13p142\n qt5-x11extras: 5.15.13p0\n qt5-xml: 5.15.13p142\n qt5-xmlpatterns: 5.15.13p0\n re2: 20240401\n readline: 8.2.10\n shaderc: 2024.0\n shared-mime-info: 2.2_2\n snappy: 1.2.0\n speech-dispatcher: 0.11.2_4\n speexdsp: 1.2.1\n sqlite: 2.8.17_5\n sqlite3: 3.45.1,1\n svt-av1: 2.0.0\n tiff: 4.4.0_3\n uchardet: 0.0.8_1\n unixODBC: 2.3.12_1\n vmaf: 3.0.0\n vulkan-headers: 1.3.283\n vulkan-loader: 1.3.283\n wayland: 1.22.0\n webp: 1.4.0\n webrtc-audio-processing0: 0.3.1_3\n x265: 3.5_1\n xcb-util: 0.4.1,1\n xcb-util-image: 0.4.1\n xcb-util-keysyms: 0.4.1\n xcb-util-renderutil: 0.3.10\n xcb-util-wm: 0.4.2\n xdg-utils: 1.1.3_4\n xkeyboard-config: 2.41_4\n xorg-fonts-truetype: 7.7_1\n xorgproto: 2023.2\n xprop: 1.2.7\n xset: 1.2.5_1\n xxhash: 0.8.2_1\n zstd: 1.5.6\n\n Number of packages to be installed: 270\n\n The process will require 3 GiB more space.\n\n Proceed with this action? [y/N]:\n ```\n\n ```\n pkg install qt5-buildtools qt5-core qt5-gui qt5-linguisttools qt5-testlib qt5-widgets\n Updating local repository catalogue...\n local repository is up to date.\n All repositories are up to date.\n Checking integrity... done (0 conflicting)\n The following 79 package(s) will be affected (of 0 checked):\n\n New packages to be INSTALLED:\n brotli: 1.1.0,1\n dbus: 1.14.10_5,1\n dejavu: 2.37_3\n double-conversion: 3.3.0\n encodings: 1.1.0,1\n expat: 2.6.2\n font-bh-ttf: 1.0.3_5\n font-misc-ethiopic: 1.0.4\n font-misc-meltho: 1.0.3_5\n fontconfig: 2.15.0_2,1\n freetype2: 2.13.2\n gettext-runtime: 0.22.5\n glib: 2.80.0,2\n graphite2: 1.3.14\n harfbuzz: 8.4.0\n hicolor-icon-theme: 0.17\n icu: 74.2_1,1\n indexinfo: 0.3.1\n jpeg-turbo: 3.0.2\n libICE: 1.1.0_2,1\n libSM: 1.2.3_1,1\n libX11: 1.8.9,1\n libXau: 1.0.9_1\n libXdmcp: 1.1.5\n libXext: 1.3.6,1\n libXfixes: 6.0.0_1\n libXi: 1.8_1,1\n libXmu: 1.1.4,1\n libXrender: 0.9.10_2\n libXt: 1.3.0,1\n libepoll-shim: 0.0.20230411\n libevdev: 1.13.1\n libffi: 3.4.4_1\n libfontenc: 1.1.8\n libglvnd: 1.7.0\n libgudev: 237\n libiconv: 1.17_1\n libinput: 1.25.0\n liblz4: 1.9.4_1,1\n libmtdev: 1.1.6_1\n libudev-devd: 0.5.2\n libwacom: 1.5_1\n libxcb: 1.17.0\n libxkbcommon: 1.6.0_2\n libxml2: 2.11.7\n mkfontscale: 1.2.3\n mpdecimal: 4.0.0\n pcre2: 10.43\n png: 1.6.43\n py39-evdev: 1.6.0\n py39-packaging: 24.0\n py39-pyudev: 0.22.0\n py39-setuptools: 63.1.0_1\n py39-six: 1.16.0\n python39: 3.9.18_2\n qt5-buildtools: 5.15.13p142\n qt5-core: 5.15.13p142\n qt5-dbus: 5.15.13p142\n qt5-gui: 5.15.13p142\n qt5-linguisttools: 5.15.13p4\n qt5-network: 5.15.13p142\n qt5-testlib: 5.15.13p142\n qt5-widgets: 5.15.13p142\n qt5-xml: 5.15.13p142\n readline: 8.2.10\n vulkan-headers: 1.3.283\n wayland: 1.22.0\n xcb-util: 0.4.1,1\n xcb-util-image: 0.4.1\n xcb-util-keysyms: 0.4.1\n xcb-util-renderutil: 0.3.10\n xcb-util-wm: 0.4.2\n xdg-utils: 1.1.3_4\n xkeyboard-config: 2.41_4\n xorg-fonts-truetype: 7.7_1\n xorgproto: 2023.2\n xprop: 1.2.7\n xset: 1.2.5_1\n zstd: 1.5.6\n\n Number of packages to be installed: 79\n\n The process will require 381 MiB more space.\n\n Proceed with this action? [y/N]:\n ```\n\nACKs for top commit:\n hebasto:\n re-ACK dace02f99d4a8785567732c0d687517175765bfd.\n\nTree-SHA512: 388fccb91ed677326592f5f73fa9ff7f341886a44b56364dfb1a683f29cd988e8751f64f645f200a01725086c789ebf9cabdaf412eb1cde742c8d7efc5165d94","shortMessageHtmlLink":"Merge #29932: doc: suggest only necessary Qt packages for installatio…"}},{"before":"9e0e51b1d9f9c9bf95bc2c56f29ae32fa479c3b3","after":"631a2b5b3f2a9db6007c5c3e74e576d34e581d54","ref":"refs/heads/master","pushedAt":"2024-04-24T13:00:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29947: doc: Suggest only necessary Qt packages for installation on OpenBSD\n\n970cbc3172b73e1faf6bdb429400d3497cbb9d33 doc: Suggest only necessary Qt packages for installation on OpenBSD (Hennadii Stepanov)\n\nPull request description:\n\n The currently suggested `qt5` installs many unneeded dependencies, for example, `qtsensors`, `qtspeech` etc.\n\n Similar to https://github.com/bitcoin/bitcoin/pull/29932.\n\nACKs for top commit:\n theStack:\n re-ACK 970cbc3172b73e1faf6bdb429400d3497cbb9d33\n\nTree-SHA512: c680a4f88c27cae145822f30d9856fe76b856c6b11babe652c7171f4322dbe7af8725cccf8b45295067690ed98aa3f6329a8b65a59f31348854638ac375372d1","shortMessageHtmlLink":"Merge #29947: doc: Suggest only necessary Qt packages for installatio…"}},{"before":"19d59c9cc6078df7927eec3fe34a292121909041","after":"9e0e51b1d9f9c9bf95bc2c56f29ae32fa479c3b3","ref":"refs/heads/master","pushedAt":"2024-04-24T12:55:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29870: rpc: Reword SighashFromStr error message\n\nfa6ab0d020d0b1492203f7eb2ccb8051812de086 rpc: Reword SighashFromStr error message (MarcoFalke)\n\nPull request description:\n\n Put quotes around the parameter. In theory, `std::quoted` should be used, but that seems overkill.\n\n This should avoid error messages such as `A valid sighash parameter is not a valid sighash parameter. (code -8)`.\n\n Also, it should fix fuzz false positives when searching for internal bugs in the `rpc` fuzz target. For example, `ZGVzY3JpcHRvcnByb2Nlc3Nwc2J0XP9ce1tdXOVJbnRlcm5hbCBidWcgZGV0ZWN0ZWQAXQ0AHfcAXQ1p7TJv`.\n\nACKs for top commit:\n dergoegge:\n ACK fa6ab0d020d0b1492203f7eb2ccb8051812de086\n brunoerg:\n utACK fa6ab0d020d0b1492203f7eb2ccb8051812de086\n\nTree-SHA512: e2c0cc0126de61873a863af38b7b0a23d2dadd596ca0418dae2ad091e8acfb6a9d657c376d59187bb008989dc78c6b44fe518590e5217e4049a867b220c9fb18","shortMessageHtmlLink":"Merge #29870: rpc: Reword SighashFromStr error message"}},{"before":"19722e3e728933e629eb8e407075fb193b2908e2","after":"19d59c9cc6078df7927eec3fe34a292121909041","ref":"refs/heads/master","pushedAt":"2024-04-24T11:15:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29882: netbase: clean up Proxy logging\n\nfb4cc5f423ce587c1e97377e8afdf92fb4850f59 netbase: clean up Proxy logging (Matthew Zipkin)\n\nPull request description:\n\n Follow up to #27375 and see https://github.com/bitcoin/bitcoin/pull/29649#issuecomment-2057456834\n\n This removes an extra log message when we can't connect to our own proxy, and another when the proxy is invalid.\n\n ## Before #27375 if proxy is unreachable\n\n ```\n 2024-04-15T17:54:51Z connect() to 127.0.0.1:9999 failed after wait: Connection refused (61)\n 2024-04-15T17:54:52Z connect() to 127.0.0.1:9999 failed after wait: Connection refused (61)\n 2024-04-15T17:54:52Z connect() to 127.0.0.1:9999 failed after wait: Connection refused (61)\n 2024-04-15T17:54:53Z connect() to 127.0.0.1:9999 failed after wait: Connection refused (61)\n 2024-04-15T17:54:53Z connect() to 127.0.0.1:9999 failed after wait: Connection refused (61)\n ```\n\n ## After #27375 if unix proxy is unreachable:\n\n ```\n 2024-04-15T17:54:03Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T17:54:03Z Cannot connect to socket for /Users/matthewzipkin/Desktop/tor\n 2024-04-15T17:54:04Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T17:54:04Z Cannot connect to socket for /Users/matthewzipkin/Desktop/tor\n 2024-04-15T17:54:04Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T17:54:04Z Cannot connect to socket for /Users/matthewzipkin/Desktop/tor\n 2024-04-15T17:54:05Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T17:54:05Z Cannot connect to socket for /Users/matthewzipkin/Desktop/tor\n ```\n\n ## After this PR:\n\n ```\n 2024-04-15T18:18:51Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T18:18:51Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T18:18:52Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n 2024-04-15T18:18:52Z connect() to /Users/matthewzipkin/Desktop/tor failed: No such file or directory (2)\n ```\n\nACKs for top commit:\n tdb3:\n CR ACK for fb4cc5f423ce587c1e97377e8afdf92fb4850f59\n laanwj:\n ACK fb4cc5f423ce587c1e97377e8afdf92fb4850f59\n\nTree-SHA512: f07b9f7f2ea9f4bc01780c09f0b076547108294a1fa7d158a0dd48d6d7351569e461e5cccf232b7b1413ce2e3679668e523e5a7c89cd58c909da76d3dcbc34de","shortMessageHtmlLink":"Merge #29882: netbase: clean up Proxy logging"}},{"before":"a7129f827c9de1330dea1fec739ca210e6bda3cb","after":"19722e3e728933e629eb8e407075fb193b2908e2","ref":"refs/heads/master","pushedAt":"2024-04-24T10:07:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29929: ci: Drop no longer needed `-I` flag in \"tidy\" task\n\n6f5954acac2ced22dae7088e2b679bf663507d4c ci: Drop no longer needed `-I` flag in \"tidy\" task (Hennadii Stepanov)\n\nPull request description:\n\n As title says.\n\nACKs for top commit:\n maflcko:\n lgtm ACK 6f5954acac2ced22dae7088e2b679bf663507d4c\n\nTree-SHA512: 4d1cf6eb93bb4b9c51637d182e1fa585263fd998077ec66f34909d69cea070f78fe706a01cca1704dbd1c80465270f874d68972e470506b6b2032dc8bfc20ccc","shortMessageHtmlLink":"Merge #29929: ci: Drop no longer needed -I flag in \"tidy\" task"}},{"before":"7c17f203a5fdc697dd1cf78a9f6c6e7f49a0567d","after":"a7129f827c9de1330dea1fec739ca210e6bda3cb","ref":"refs/heads/master","pushedAt":"2024-04-23T21:21:05.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#24313: Improve display address handling for external signer\n\n4357158c4712d479522d5cd441ad4dd1693fdd05 wallet: return and display signer error (Sjors Provoost)\ndc55531087478d01fbde4f5fbb75375b672960c3 wallet: compare address returned by displayaddress (Sjors Provoost)\n6c1a2cc09a00baa6ff3ff34455c2243b43067fb5 test: use h marker for external signer mock (Sjors Provoost)\n\nPull request description:\n\n * HWI returns the requested address: as a sanity check, we now compare that to what we expected\n * external signer documentation now reflects that HWI alternatives must implement this check\n * both RPC and GUI will now return an error text, rather than just fail (the GUI even failed silently in some cases)\n\nACKs for top commit:\n brunoerg:\n ACK 4357158c4712d479522d5cd441ad4dd1693fdd05\n achow101:\n ACK 4357158c4712d479522d5cd441ad4dd1693fdd05\n\nTree-SHA512: 4f56edf3846745c8e7d08ef55cf29e8bb468256457149377c5f02da097931f9ca0c06bdbd856dc2385cde4fd11e4dc3b634c5a48814ff27f5562c8a25d43da93","shortMessageHtmlLink":"Merge #24313: Improve display address handling for external signer"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEPRQELgA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin/bitcoin"}