Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tolerances for 'incorrect' algorithms, when more strict than defaults #4633

Open
1 task done
luciansmith opened this issue Mar 23, 2023 · 0 comments
Open
1 task done
Labels
bug Something isn't working
Projects

Comments

@luciansmith
Copy link

Contact Details

No response

Location

runBiosimulations

What happened?

Models that succeed using LSODA sometimes do not succeed using CVODE, due to needing to turn on/off the 'stiff' solver, and/or set tolerances to be more restrictive.

However, you currently can't create a SED-ML file that tells you what the tolerances should be for both algorithms. This should also be solved, but in the meantime, it should be possible to create SED-ML for LSODA with extra-strict tolerances which will work for both LSODA and CVODE.

However, currently, if the base algorithm is LSODA but the simulator uses CVODE, all algorithm parameters are ignored.

Often this is a good thing: LSODA tolerances are often set higher than default CVODE tolerances, and you need the defaults to successfully simulate the model. But in the reverse case, when the tolerances are more restrictive than the defaults, biosimulations should use the more restrictive values.

What made it happen?

Simulate a LSODA simulation on a CVODE simulator

Version

Production (Deployed on a .org domain)

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luciansmith luciansmith added the bug Something isn't working label Mar 23, 2023
@github-actions github-actions bot added this to Needs triage in 🐛 Triage Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
🐛 Triage
Needs triage
Development

No branches or pull requests

1 participant