-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate away from travis-ci? #952
Comments
Updates travis-ci.org references to travis-ci.com. Refer to biojava#952.
Updates travis-ci.org references to travis-ci.com. Refer to biojava#952.
Just want to add some notes on things I tried recently. I did the migration from travis-ci.org and travis-ci.com. It has been working fine for some time. But as you say perhaps we are reaching the limits of the free tier. What I've struggled with is in running CI with Pull Requests. Both travis-ci.com and github workflows broke down at some point (they would sit there waiting forever). At the moment, it seems that travis-ci does work fine for PRs, but I have disabled github workflow in PRs. Perhaps it will work now if we try again. In the per-commit CI, it seems that both CI systems work well, judging from the latest commit : |
Now github workflows are the only enabled CI for BioJava. However the github workflow build is failing due to the openchart dependency of biojava-alignment (itself a dependency of the forester package, see cmzmasek/forester#12 for some background):
In other environments this was simply a warning instead of a failure:
There must be something in github workflow environment (maven version?) that's producing this error now. |
I think helping forester publish to Maven Central is the best way forward, hopefully we can help make that happen. |
Forester itself is in maven central (we did it ourselves, in the biojava-thirdparty namespace). What's not in maven central is the openchart dependency that forester has. See our foresters's fork pom: <!-- Openchart is not available in maven central. The only way we can provide
it is by pointing to the jar within the distribution. That's not ideal and
maven warns about it. -->
<dependency>
<artifactId>openchart</artifactId>
<groupId>openchart</groupId>
<version>1.0</version>
<scope>system</scope>
<systemPath>${basedir}/src/main/resources/openchart.jar</systemPath>
</dependency>
If openchart source code was available somewhere and their license allowed it, we could try to host it under biojava-thirdparty. |
I've stumbled upon the same build problem. And it looks like |
System scope is disabled in new maven versions. Look at this Page. |
Thanks for the tip @vasiliy-bout . I've tried that, but the jar file that the jboss repo provides seems to be corrupted:
Thanks @aalhossary , that confirms it is a maven version problem |
@josemduarte , this is strange. Here is my output:
So the JAR looks good in my maven cache. I'm using AdoptOpenJDK-11.0.11+9. |
Thanks again @vasiliy-bout . After some more debugging, it turns out that our local maven repo (nexus3) had a bad jar in the cache. So yes, it works with the jboss jar. I'll see if I can push that later today. |
I've released a new biojava-thirdparty/forester (1.039) and bumped the version up in biojava's pom (pushed to master already). The test now passes. Now we have the next problem: biojava-protmod depends on an external resource that's no longer available, see #975 |
For the moment, to get the CI pipeline going, I'm going to |
Github workflows are now working both for pushes to master and pull requests. |
In June travis-ci.org was shut down and migrated to travis-ci.com. This apparently involves stronger limits on computation time for free projects. As a result many projects (e.g. biopython) are migrating to github actions. Should biojava do the same?
Another option might be to apply for an OSS Credits allowance to continue running on travis-ci. If I'm reading their plans correctly, this might not even be needed since we only test on linux and we rarely have more than one concurrent job.
For reference, in July we ran 15 builds and 289 minutes.
The text was updated successfully, but these errors were encountered: