Test Smell: it is not a good test practice to use the loop in the test

[TestSmell]

Hi!

We notice that you use the loop structure in your test cases.
For example, testQualityScoresIntArray() in FastqToolsTest.java

However, using the loop in test cases is not a good test practice.
We analyzed the relevant Stack Overflow posts and summarized four potential negatives it brings:

1. Loops make the test case more complex
2. In most cases, a loop can be replaced with a data-driven test that is more readable.
3. Loops break the assert-for-one-thing thumb rule. I don't mean a single assert statement.
4. When a test fails, knowing the reason is more complicated.

Solution:
To avoid using the loop in the test, JUnit provides an annotation (i.e., @ParameteredTest), enabling a test case to run multiple times with different parameters.
We provide a usage example here:

[josemduarte]

Good point, thanks! Would you be able to provide a pull request?

[tmrpavan]

@josemduarte I would like to work on this. We are using Junit4 is there any chance to migrate Junit5. So this type of test case are easy to write in Junit5

[josemduarte]

Yes we have in fact converted some tests to junit5 and the agreement is that new tests should be junit5.

[tmrpavan]

can you assign this issue to me. I will work on this