Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of ontology module #1013

Open
richarda23 opened this issue Jan 4, 2022 · 1 comment
Open

Maintenance of ontology module #1013

richarda23 opened this issue Jan 4, 2022 · 1 comment

Comments

@richarda23
Copy link
Contributor

Hi,
Been looking at the ontology module as it might be useful in my day job.
I tried parsing the latest GO flatfile at http://geneontology.org/docs/download-ontology/#go_basic and the parser handles it OK (ie it doesn't crash). But with the low number of tests, documentation and sample code it's hard to be confident that it's parsing everything correctly for use in production system.

Would it be worth giving this module a bit of attention? Specifically

  • enhancing test coverage especially w.r.t supporting OBO spec
  • improving Javadoc and sample code
  • adding a README to the project
  • updating code style/formatting and using more modern Java 7/8 idioms (once test coverage is much better)

Also, I'm interested in using Go annotation format files - http://geneontology.org/docs/go-annotation-file-gaf-format-2.2 - is a parser for this something that would belong in this module?

I'd be happy to take a stab at some of these tasks unless there are strong contrary opinions.

@richarda23 richarda23 changed the title Maintenance of ontology modue Maintenance of ontology module Jan 4, 2022
@josemduarte
Copy link
Contributor

Would it be worth giving this module a bit of attention? Specifically
enhancing test coverage especially w.r.t supporting OBO spec
improving Javadoc and sample code
adding a README to the project
updating code style/formatting and using more modern Java 7/8 idioms (once test coverage is much better)

I would say yes to all of those. The module can be definitely useful for many people. Over recent years it has come up in questions here and there (though we lacked a maintainer). So I think it's worth investing some time to refresh it.

Also, I'm interested in using Go annotation format files - http://geneontology.org/docs/go-annotation-file-gaf-format-2.2 - is a parser for this something that would belong in this module?

Yes, to me this module looks like the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants