Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABITrace method getImageReverted to represent RC of trace. #40

Open
el1jaC opened this issue Mar 14, 2018 · 7 comments
Open

ABITrace method getImageReverted to represent RC of trace. #40

el1jaC opened this issue Mar 14, 2018 · 7 comments

Comments

@el1jaC
Copy link

el1jaC commented Mar 14, 2018

Hello and sorry for my english!

For my needs i developed a custom method in ABITrace.java that returns the trace's reverse complement counterpart .

I've used Apache Commons, but i can rewrite the piece of code using pure Java API.

Is it possible to do a pull request to evaluate my code?

@josemduarte
Copy link

Sure pull requests are welcome! But please beware that the biojava-legacy project is only minimally maintained.

What would be really cool is to port the ABI reading feature to the current biojava. See biojava/biojava#574 and biojava/biojava#535

Once in the active biojava project it would be actively maintained, so its lifetime would be greatly extended.

@heuermh
Copy link
Member

heuermh commented Mar 14, 2018

@el1jaC Please do submit a pull request here, and then as @josemduarte says, if you have time to port to the current code biojava/biojava codebase and pull request there, it would be appreciated.

@el1jaC
Copy link
Author

el1jaC commented Mar 15, 2018

Hi @josemduarte and @heuermh ,

sure I'll try to port the code of ABITrace.java in new biojava repository, but it may take a bit of time.
Is there a definite deadline about this?

@lafita
Copy link
Member

lafita commented Mar 15, 2018

We welcome pull requests and contributions anytime, so there is no deadline really. As soon as you think the code is ready you can submit it.

@el1jaC
Copy link
Author

el1jaC commented Mar 15, 2018

In order to porting code in new biojava repository, are you using some IDE to mantain it?

@josemduarte
Copy link

The IDE that you use is your choice. Personally I like Eclipse, although I'm also using IntelliJ these days and it is pretty impressive.

In any case we are not enforcing any formatting standards at the moment if that's your question.

@el1jaC
Copy link
Author

el1jaC commented Mar 16, 2018

Are you using community edition of IntelliJ?

Actually I'm using Netbeans, and I feel really good with him :)

But I love Jetbrains products, and Intellij seems to be the best Java IDE right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants