@cassiemk @reece can likely explain this better, but I will try to give it a shot!

You are correct; the package does return no protein change for converted sequence variants based on the nomenclature when offsets are provided, like in your top 3 examples.

I believe this is working as designed, because we cannot guarantee that every splice site/region will be unaffected/remain intact by intronic variants.

I am unsure if there are plans to change this or add edge cases for specific variants where the coding regions are not affected. I will defer to Reece to comment on that.

@katiestahl
when there's an insertion right at the intron/exon boundary, there is a choice to make. Should the inserted material be treated as part of the coding region (because the canonical splice site and in fact the entire intron is intact), or as part of the intron (because it is adjacent to the canonical splice site).

Currently, the behavior is inconsistent.

the 4 examples from the original issue are all insertions right at the boundary. 3 of them are treated as intronic, and 1 is treated as CDS. And the difference seems to be arbitrary, based on whether the cdot nomenclature includes an intronic position or not. So a conscious decision has not yet been made.

We have a developer working on updating the logic so that insertions at the boundary are treated as CDS, and were planning a pull request sometime soon once we get all of our tests passing. This seems to be the more common choice, and is the choice that our users seem to expect.

So the immediate task would be to see if we can come to alignment about which decision is most appropriate for insertions right at the boundary. As far as I can tell, HGVS (the society) doesn't have any guidance on this situation (they don't talk much about the right decisions to make for edge cases when projecting DNA changes onto transcripts).

Reasons we think these insertions should be treated as part of the coding region:

• the canonical splice site, and the entire intron are fully intact
• it's very difficult to say what actually happens in the cell, and is certainly context dependent, context that we don't have. So it should default to the most "visible" change, i.e. one with an aa-change. For example, to avoid any filters that eliminate non-coding variants

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.

Would it be possible to re-open this issue? It is a flaw with a PR out to fix it.

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.