Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping patches #68

Open
hussein-jafarinia opened this issue Feb 20, 2023 · 3 comments
Open

Overlapping patches #68

hussein-jafarinia opened this issue Feb 20, 2023 · 3 comments

Comments

@hussein-jafarinia
Copy link

Hi
Thanks for the wonderful paper and very clear code.
I have a question. Do you think that your model will still work if we give it overlapping patches? (I need to remove healthy patches from a bag of overlapping patches of WSIs on TCGA)

@PiumiDS
Copy link

PiumiDS commented Mar 9, 2023

Hi @hussein-jafarinia

Have you checked the image patches shared by Bin? It seems to me that the patches were already extracted with overlap as I saw the same patch repeated. I am confused about the patch extraction step so really appreciate your feedback.

Best regards.

@hussein-jafarinia
Copy link
Author

Hi @hussein-jafarinia

Have you checked the image patches shared by Bin? It seems to me that the patches were already extracted with overlap as I saw the same patch repeated. I am confused about the patch extraction step so really appreciate your feedback.

Best regards.

By overlap I don't mean same patches repeating. I mean for example a patch having 50% overlap with other patches in it's horizontal and vertical axes (which is something that some methods on histopathology do at least for their training process)
I haven't checked the details of their tiling/patching code for training(deepzoom_tiler.py). But the result of test_crop_single.py isn't overlapping (I've run it) and based on what the paper says and shows in it's figures it seems like their patches aren't overlapping.

@Rainydu184
Copy link

Rainydu184 commented Mar 31, 2023

it may be not work well in overlapping patches, the same area will influence the distance between the different patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants