Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Permission not right away. #187

Open
tobstar6 opened this issue Sep 6, 2021 · 9 comments
Open

Camera Permission not right away. #187

tobstar6 opened this issue Sep 6, 2021 · 9 comments

Comments

@tobstar6
Copy link

tobstar6 commented Sep 6, 2021

Could improve maybe, on your plugin for Ninja Forms can we have option eg person can click button if they want use camera for Videomail, so it won’t show camera access permission straight away. For example we build one page website with form on bottom so when visitors get on home page they don’t have to see camera access permission and turn them off. Same with contact page. No need ask permission straight away until person decide to click to use Videomail then ask them permission for camera access.

@aylacullen
Copy link

Seconding this. I am using this in the support button that loads at the bottom right of every page. This means when a visitor lands on the webpage, it immediately asks for video permissions. So it should only request permissions when clicked.

@binarykitchen
Copy link
Owner

@aylacullen interesting, I hear you. Can I see a live example of your website where this happens?

@aylacullen
Copy link

@binarykitchen See: https://deafhistorycollections.com.au/

Click on button with hand icon at bottom right, click on video message. That's where it will appear. Since it loads on all pages due to that button being available everywhere, it means the website is repeatedly asking for permission as the user navigates throughout the website. It should only ask permission when for example, a button is clicked to leave a message.

If you test it out right now, you'll see that portion is disabled. It's because right now I'm working on finding a workaround to it to compensate since I wasn't sure if you'd be able to look into the issue anytime soon. One thought I had was setting it up so there's no shortcode in the section calling the ninja form that contains the video mail module, then when the user clicks 'leave video message', it executes a javascript function that subequently loads the ninja form into that section, which in theory will result in the browser asking for permission. So far, I'm having trouble getting it to find the section for executing .innerHTML to replace the code (yes, I'm actively coding it right now as of the time of this post).

If you have better ideas for the workaround I outlined above, I'm all eyes. Thanks so much for the quick response.

@binarykitchen
Copy link
Owner

@aylacullen Thanks for the prompt response.

Hmmm, on deafhistorycollections.com.au I see a coming soon page and a waiting list of subscription form (which I've just submitted).

If you test it out right now, you'll see that portion is disabled.

Can you please set up a second domain for tests only, like test.deafhistorycollections.com.au, password-protect it, remove the waiting list and enable that portion?

Only that way, I can properly test, reproduce and fix it. Thanks.

@aylacullen
Copy link

I've emailed you a test account you can use to login. Once logged in, go back to the homepage and hit refresh. It will load and bypass the coming soon page. I've re-enabled the video mail module for you to see it in action.

@binarykitchen
Copy link
Owner

Ah, I can reproduce it now. Screenshots always help btw.

Understand, it's frustrating for UX/UI.

permission request

@binarykitchen
Copy link
Owner

Well, it's an interesting situation. For example, when you arrive at the main Videomail site, www.videomail.io, we want the live video feed to show up right away without pressing any button.

But in your example, it's different. Right, because WordPress loads all the assets right away, no matter if you need them or not, this scenario requires special treatment ㋛

Responsible code:
https://github.com/binarykitchen/videomail-client/blob/develop/src/js/wrappers/visuals/recorder.js#L1274

Maybe a new WordPress option whether to show the video live feed right away or not would help with this cause?
A switch saying like "Show video now or on the press of the record button?"

What do you think?

PS: @tobstar6 Peace out ;)

@aylacullen
Copy link

aylacullen commented Feb 15, 2024 via email

@binarykitchen
Copy link
Owner

Cool @aylacullen, thanks for confirming.

Well, I have kids and a full-time job. Let's discuss the timeline and requirements over email, and keep this thread for the technical details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants