Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readExifFromBytes & readExifFromFile are marked as Async but are technically Sync function #33

Open
PapyElGringo opened this issue Jun 30, 2022 · 1 comment
Labels
area/api Indicates an issue on api area. enhancement

Comments

@PapyElGringo
Copy link

Future<Map<String, IfdTag>> readExifFromBytes(List<int> bytes,
    {String? stopTag,
    bool details = true,
    bool strict = false,
    bool debug = false,
    bool truncateTags = true}) async {
  return readExifFromFileReader(FileReader.fromBytes(bytes),
          stopTag: stopTag,
          details: details,
          strict: strict,
          debug: debug,
          truncateTags: truncateTags)
      .tags;
}

Since readExifFromFileReader is a sync function readExifFromBytes should be too.
It's currently make us believe that there is some async process running

@bigflood bigflood added enhancement area/api Indicates an issue on api area. labels Jul 2, 2022
@bigflood
Copy link
Owner

bigflood commented Jul 2, 2022

you're right.
I'll consider it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants