Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED controls only appear on one gang of multi gang dimmer #71

Open
bigbadblunt opened this issue Apr 23, 2022 · 17 comments
Open

LED controls only appear on one gang of multi gang dimmer #71

bigbadblunt opened this issue Apr 23, 2022 · 17 comments

Comments

@bigbadblunt
Copy link
Owner

some of the dimmers have changed their buttons from sliders to lightning bolts though which is pretty weird...

@SGXander can you describe a bit more? Does this revert when you go back to the websocket connection? What kind of devices are affected - are these gen 1 or 2?

afraid not. they don't seem to have lost any functionality but lovelace is picking them up like that now. All Gen2 and seems to only be left of the 2-gang dimmers... yes definately only the left of the 2-gang units showing that.

also the lw600 energy monitor isnt reporting in on the public API. I'll switch back a bit later on to see if it's the same on websocket

Originally posted by @SGXander in #69 (comment)

@bigbadblunt bigbadblunt changed the title > > some of the dimmers have changed their buttons from sliders to lightning bolts though which is pretty weird... Incorrect detection of generation of multi-gang dimmer Apr 23, 2022
@bigbadblunt
Copy link
Owner Author

Can you send me a log which shows the setup of the component? The problem appears to be that these devices are being interpreted as gen 1, but I'm not sure why.

@SGXander
Copy link

H01-D1-L
H01-D1-R

looks like there is some difference between the left and right gangs. I know in websocket mode the left (being the secondary on the rear of the dimmer) was detected as an unknown model. this is correct using the public api but the LED is marked as unavailable.

let me know where the log is found and will upload it

@bigbadblunt
Copy link
Owner Author

Through the web interface at https://address.to.ha/config/logs

or in homeassistant.log in your home assistant install folder.

@SGXander
Copy link

2022-04-23 10:46:34 WARNING (SyncWorker_4) [homeassistant.loader] We found a custom integration lightwave2 which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-04-23 10:46:40 WARNING (MainThread) [custom_components.lightwave2] Using Public API, this is experimental - if you have issues turn this off in the integration options

Is all I have in the log relating to lightwave. Rest are cert errors which I need to have a look at separately.

@bigbadblunt
Copy link
Owner Author

bigbadblunt commented Apr 23, 2022

Can you turn on full logging in the integration options,
image

then press the "load full home assistant log"
image

@SGXander
Copy link

Too much for the phones clipboard to handle so give me 5 and I'll get the laptop

@SGXander
Copy link

Log.txt

@SGXander
Copy link

Sorry to clarify: I haven't tried websocket again yet but assume it is ok on there given it was before switching. I'll give that a go a bit later on.

@bigbadblunt
Copy link
Owner Author

Have pushed a new beta release, hopefully fixed.

@SGXander
Copy link

That's fixed it thank you mate! Looks like the LW600 is reporting in again too.

@SGXander
Copy link

Ah sorry doesn't seem to have fixed the LEDs just the toggles. LEDs still unavailable on the left gangs

@bigbadblunt bigbadblunt reopened this Apr 23, 2022
@bigbadblunt
Copy link
Owner Author

Are the leds on a two-gang switch separately controllable? The api is only returning one entry for an led - I'm not sure if there should be two separate led control, or just duplicate the same led across both switches?

@SGXander
Copy link

They seem to change together on the app. Maybe duplicate the LED controller for both? The websocket must enumerate one for both but the link or the dimmer just knows to set the same setting when called...

@garysargentpersonal
Copy link

My Gen 1 single socket is showing the same lightning icons via the public API, rather than the toggle switch.

2022-04-23 17:54:55 DEBUG (MainThread) [lightwave2.lightwave2] async_get_hierarchy: Creating device {'featureSetId': '610e7eb94ba41f668b77fe03-617830a7f130e15ac40b7d0b', 'name': 'Oven Cupboards', 'features': [{'featureId': '610e7eb94ba41f668b77fe03-431-3157355974+1', 'type': 'switch', 'writable': True}, {'featureId': '610e7eb94ba41f668b77fe03-432-3157355974+1', 'type': 'protection', 'writable': True}, {'featureId': '610e7eb94ba41f668b77fe03-433-3157355974+1', 'type': 'identify', 'writable': True}]} 2022-04-23 17:54:55 DEBUG (MainThread) [lightwave2.lightwave2] async_get_hierarchy: Adding device features {'featureId': '610e7eb94ba41f668b77fe03-431-3157355974+1', 'type': 'switch', 'writable': True} 2022-04-23 17:54:55 DEBUG (MainThread) [lightwave2.lightwave2] async_get_hierarchy: Adding device features {'featureId': '610e7eb94ba41f668b77fe03-432-3157355974+1', 'type': 'protection', 'writable': True} 2022-04-23 17:54:55 DEBUG (MainThread) [lightwave2.lightwave2] async_get_hierarchy: Adding device features {'featureId': '610e7eb94ba41f668b77fe03-433-3157355974+1', 'type': 'identify', 'writable': True}

@bigbadblunt
Copy link
Owner Author

They seem to change together on the app. Maybe duplicate the LED controller for both? The websocket must enumerate one for both but the link or the dimmer just knows to set the same setting when called...

OK. This will be tricky to fix. The two connection methods return the hierarchy very differently, and it's not very straightforward to connect the two entities together. I will have a look at fixing at some point, but I don't think this is affecting any functionality?

@bigbadblunt
Copy link
Owner Author

My Gen 1 single socket is showing the same lightning icons via the public API,

This is as expected. I think this should also be the case on the websocket? Home Assistant standard behaviour for devices that don't report their state is to show both on and off controls at all times.

If the websocket is giving a toggle control for gen 1 devices, that's a bug.

@SGXander
Copy link

They seem to change together on the app. Maybe duplicate the LED controller for both? The websocket must enumerate one for both but the link or the dimmer just knows to set the same setting when called...

OK. This will be tricky to fix. The two connection methods return the hierarchy very differently, and it's not very straightforward to connect the two entities together. I will have a look at fixing at some point, but I don't think this is affecting any functionality?

No it doesn't seem to be affecting anything important, the main issue is far more important than this!

@bigbadblunt bigbadblunt changed the title Incorrect detection of generation of multi-gang dimmer LED controls only appear on one gang of multi gang dimmer May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants