Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not pulling in correct names of devices #120

Closed
ITHungry opened this issue Oct 13, 2023 · 35 comments
Closed

Not pulling in correct names of devices #120

ITHungry opened this issue Oct 13, 2023 · 35 comments

Comments

@ITHungry
Copy link

I have 56 devices of lightwave RF all generation 2

3 Single light dimmer switches (Product code: L21)
and 53 Smart Socket, 2 gang, (Product code: L42) ranging from L42, L42MK2, L42MK3.

when setting up the names in the lightwave up thats fine, however the latest Smart Socket, 2 gang, (Product code: L42MK3) ive just added yesterday is not pulling the correct name through Hacs on HA, just wondering if this is a limitation of the code due to how many devices I have?

Anybody else seeing this or is it just me?
I've done a thew things to check, like deleting the Hacs intergration restarting HA Yellow, reinstallaing the intergration and then
reconnecting but the same thing I get each time.

I know some of the previous sockets also pull in the rong name but I belive this is down to when I first lightwave, and changed the name multipil times in the lightwave app.

Just seems to be an issue more now with adding new sockets in.

I called the socket Office-Socket 6 on the lightwave app, but when it pulled the socket through the Hacs intergration it called it Switch 1254 for the Left Hand socket and called it identify_1247 for the right hand socket..


Home Assistant Yellow
CM4 - Wireless: with, eMMC Flash: 32GB, RAM: 8GB

Home Assistant 2023.10.1
Supervisor 2023.10.0
Operating System 10.5
Frontend 20231005.0 - latest

Node-RED V3.1.0
Hacs - Lightwave RF V3.5.20

@Whizzykid
Copy link

Interesting you mention this as I saw the same recently when adding new L22 switches.
Not a big problem to fix, but I hope we can find a solution in the code.

@ITHungry
Copy link
Author

Interesting you mention this as I saw the same recently when adding new L22 switches. Not a big problem to fix, but I hope we can find a solution in the code.

Hello @Whizzykid
How many Lightwave device do you have? out of interest.

Wonder if its a limit with Lightwave hub.

@bigbadblunt
Copy link
Owner

Can you send me a log file with debugging enabled from the startup of the component?

@ITHungry
Copy link
Author

Hello @bigbadblunt
Here you go, I restarted HA after enabling logging but did not reboot OS. If you needed the OS rebooted let me know.

home-assistant_lightwave2_2023-10-16T16-32-04.699Z - Copy.log

@bigbadblunt
Copy link
Owner

I also need debug output for lightwave2.lightwave2 please

@ITHungry
Copy link
Author

ITHungry commented Oct 29, 2023

I also need debug output for lightwave2.lightwave2 please

Good Morning,
Sorry I'm not sure what your asking for? whats lightwave2.lightwave2 and how do I enable the logging for this I can only see the Lightwave v2 custom component integration which is where I enabled debug logging before.
Debug

@bigbadblunt
Copy link
Owner

I need some extra debugging info that relates to the underlying library. This should happen automatically if you've used the method you describe above, unless you're on an older version of the component.

What version of the component are you running? If it's not the latest beta, can you update to that and resubmit the log?

@ITHungry
Copy link
Author

Currently running Lightwave RF V3.5.20 - don't normally use Beta versions.

How do I go about updating the current package to a Beta version?

@bigbadblunt
Copy link
Owner

Did you install through HACs? If so, go into the component, setting menu, redownload, then check "show beta versions"

image

@ITHungry
Copy link
Author

ITHungry commented Nov 3, 2023

Sorry for the delay, yes installed through HACs now running in the latest beta.

home-assistant_lightwave2_2023-11-03T19-10-01.377Z.log

@bigbadblunt
Copy link
Owner

bigbadblunt commented Nov 5, 2023

This appears to be a fault/change with the way Lightwave is describing the objects.

Line 34 of your log file shows the information provided by Lightwave.

In case you're interested, I've reformatted and uploaded that line, line 6658 shows the problem. Normally the name of the features is the same as the name of the device, but not in this case.

Hierarchy.txt

This is possibly fixable (I would just need to get the name from somewhere else). But it would require a lot of rewriting I think. I don't know if it's a permanent change, or something one-off with your setup. If other people have the same issue, then I'll have a go at fixing.

@ITHungry
Copy link
Author

ITHungry commented Nov 6, 2023

Morning @bigbadblunt
Thank you for looking into this, don't think its just in relation to mysetup as @Whizzykid has also seen the same issue (as he points out above),

I have sent an email to one of my contacts from Lightwave, just to see if they can help or shed some light if anything has changed from there end.
👍

@ikb42
Copy link
Collaborator

ikb42 commented Nov 8, 2023

Hi, the "name" property given on the device object is effectively deprecated.
The correct (app configurable) "name"(s) is/are found in the devices featureSets which are referenced in the device featureSetGroupIds array property. FeatureSets can be read with a group read using the ids from featureSetGroupIds.
A L42x for example would have 2 featureSets which can be named independently after the device is paired.

@bigbadblunt I'll try review the code around this in the next few days and suggest a solution.

@ikb42
Copy link
Collaborator

ikb42 commented Nov 10, 2023

hi @bigbadblunt - it looks like the dependency on the lightwave2 module could be the problem.
In the manifest.json: "requirements": ["lightwave2==0.8.23"]
https://pypi.org/project/lightwave2/
This not up to date with the latest version from https://github.com/bigbadblunt/lightwave2

@ikb42 ikb42 pinned this issue Nov 15, 2023
@nelliec
Copy link

nelliec commented Nov 16, 2023

Hiya, I just wanted to add I have the same problem here with a new setup of a Link Plus with a mix of connect and smart series devices.

Happy to help troubleshoot if I can.

@ikb42
Copy link
Collaborator

ikb42 commented Nov 16, 2023

@bigbadblunt has very kindly allowed us to use his Lightwave repositories as the basis for ours.
We are in the process of setting these up under a fork of this repo and the underlying library repo.

@nelliec please take a look in HACS, search for Lightwave Smart, you should find our repository listed.
I'd be grateful if you would install that one and let me know what you find.

@nelliec
Copy link

nelliec commented Nov 16, 2023

Hi @ikb42 thanks for the reply and good luck with the development.

Unfortunately there's no Lightwave Smart listing on my HACS, only the homeassitant-lightwave2 one.

Do I need to wait, or enable something else?

N

@ikb42
Copy link
Collaborator

ikb42 commented Nov 16, 2023

Hi @nelliec yes, sorry, it's not yet listed in HACS
You can add it by going to HACS, then clicking the three dots menu top right, and choose custom repositories.

Use this in the Repository field: https://github.com/LightwaveSmartHome/homeassistant-lightwave-smart
Category is Integration

Once you've done that and restarted Home Assistant, you should then find the integration in Settings -> Devices & Services -> Add Integration

@xela1
Copy link

xela1 commented Nov 16, 2023

I'll install it on my test system and give it a spin too

@xela1
Copy link

xela1 commented Nov 16, 2023

It only seems to have imported 3 devices and everything else is just under entities
image

image

Edit: reset my dev install and it's picked them up properly, including the names of the new devices

image
But it does seem to be missing icons (https://brands.home-assistant.io/lightwave_smart/dark_icon.png)

@nelliec
Copy link

nelliec commented Nov 16, 2023

hiya,

That worked for me - all my devices have appeared and now have names :)

Neal

@ikb42
Copy link
Collaborator

ikb42 commented Nov 16, 2023

Thanks! @xela1 we have a pull request pending on the Home Assistant brands repo to add icons

@ITHungry are you in a position to test as well?

@ITHungry
Copy link
Author

Hello @ikb42
My main HA Yellow Lightwave intermigration is now not functioning at all booo, however I will first test on my test system, Will install now and feedback :-)

PS thank you for jumping onboard this topic and helping out :-)

@ITHungry
Copy link
Author

Hello @ikb42
Unfortunately this is just not working for me at all.. Maybe i'm missing something.

Lightwave

home-assistant_lightwave_smart_2023-11-17T02-54-15.752Z.log

@ikb42
Copy link
Collaborator

ikb42 commented Nov 17, 2023

hi @ITHungry thanks for the feedback. There are quite a few, what look like, unrelated errors in that log file. Can you try disabling any other custom integrations. Then remove and re-add the Lightwave Smart one.

@ITHungry
Copy link
Author

Hello @ikb42

No problem I can disable them but won’t be till I finish work tonight.

I try a few things like deleting the integration rebooting and following all steps again to install but every time I enter the user name and password. It failed.

@xela1
Copy link

xela1 commented Nov 17, 2023

@ikb42 has anything major changed in the fork that we need to test, I saw name changes, build code and the change for featureset and something around lux, but nothing else

@ikb42
Copy link
Collaborator

ikb42 commented Nov 17, 2023

@xela1 besides the renaming itself there aren't any major changes to test

@ITHungry
Copy link
Author

Hello @ikb42 Ok as requested I disabled a few devices that although work fine where not plugged in and powered on this seem to stop most errors, then I rebooted HA, and then Lightwave smart integration had pulled all sockets and lights through.
I tested some sockets and lights which all seems well they turn on and off, the only thing that has not happened is pulling the devices into the areas that they should be in, I'm assuming this is due to the error I got after entering the user name and password when I first tried the integration.

Since then I have rebooted HA and re-enabled one device that I disabled at a time then rebooting HA and checking the Lightwave Smart integration making sure it works, repeating the same until all devices that where disabled are all turned back on. all still working now.

So not sure what caused the issue. but all seems ok now!

Maybe tomorrow I will delete the integration power down HA, and then turn back on and try installing it again just to see what happens, after all this one is my test rig.

@ITHungry
Copy link
Author

Hello @ikb42
Ok Still get the same issue on my HA Yellow (main system) however after disabling Robovac integration and rebooting Lightwave Smart shows up and shows all devices.

I do note that each device is not linked to the area that it should be its just blank so I have to go in and manually add each area to each device (quite a pain) when you have 56 device to do lol, but its working :-)

Also each socket is shown as a switch rather than an outlet so have to change each socket to outlet and then add mdi:power-socket-uk for the correct icon (not sure if this is something you can resolve?

Would be good when adding the integration and when its pulling in your devices you could also add each device to the area its in or better still get it to automatically do this yet again not sure if this is possible.

Hope this helps.

@xela1
Copy link

xela1 commented Nov 19, 2023

I've now added this to my main install. Removed the old integration, restarted and added the new one. Names are pulling in correctly and all seems to be working.

I took the opportunity to rename the devices in the app first so they pull in to HA the way I want them, instead of renaming in HA, which will hopefully cause less grief down the line.

Warning to anyone else, the events and services have changed name too, so if you're using those, make sure you edit the automatons/scripts that reference them

@ikb42
Copy link
Collaborator

ikb42 commented Nov 20, 2023

@ITHungry thanks for that.
I'm not sure of why sockets are represented as switches and not outlets, perhaps @bigbadblunt can shed light on that.

Re adding mdi:power-socket-uk for the correct icon, depending on the switch vs socket representation, this might be something that can be improved

@bigbadblunt
Copy link
Owner

No reason, just never implemented it correctly :)

@ikb42
Copy link
Collaborator

ikb42 commented Nov 23, 2023

Hi, I'm working on an update that will show the sockets/outlets as such and use the UK icon plus a few changes that hopefully are improvements.

Closing this issue now as solved on the new repo

@ikb42 ikb42 closed this as completed Nov 23, 2023
@ITHungry
Copy link
Author

@ikb42
Thank you for you help in resolving and improving the integration 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants