Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed pychan Abstract Class #7

Open
antonizoon opened this issue May 21, 2015 · 1 comment
Open

Proposed pychan Abstract Class #7

antonizoon opened this issue May 21, 2015 · 1 comment
Assignees

Comments

@antonizoon
Copy link
Member

Since I am going to try and create py8chan and py420chan wrapper classes (since their APIs were based on 4chan's API), I have been refactoring the BASC-py4chan wrapper to make it more extendable.

However, maybe it might be a good idea to create an abstract class like we did in the BASC-Archiver, which defines a standard interface with default functions that is extended and overrided by py4chan or py8chan.

That way, most of the code to generate attributes can be shared, while special features of a website (such as 8chan's multiple images on one post) can also be supported with a few overrides.

@antonizoon
Copy link
Member Author

It looks like with py8chan, I have abandoned the idea of direct inheritance from py4chan (because 4chan's API stands to diverge, and 8chan will be moving to Infinity-Next). When 4chan's API shifts, that would have an effect on all the others, which often rarely change.

For now, we're just going to fork the wrapper each time and adapt it to new chans whenever necessary.

However, a pychan abstract class like that found in BASC-Archiver would still be desirable, though I would need Dan's help setting this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants