Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medium zoom opening effect #391

Open
jimblue opened this issue Dec 9, 2022 · 3 comments
Open

Medium zoom opening effect #391

jimblue opened this issue Dec 9, 2022 · 3 comments
Labels
enhancement feature-request New Feature / Plugin Candidate

Comments

@jimblue
Copy link

jimblue commented Dec 9, 2022

It would be awesome to make a smoother transition between the thumbnail and the ligthbox like in Medium.

There is already this medium zoom npm package but it only works for single image.

@gingerchew
Copy link
Collaborator

That's a really cool idea, @jimblue!

Unfortunately, it would be tough to integrate something like for 2 reasons.

  1. GLightbox has a general rule of 0 dependencies
  2. The way medium zoom handles the image transition wouldn't work with the current GLightbox slide creation.

Currently the way the GLightbox slides are generated, the whole lightbox is generated on the fly. That makes handling the zoom/transition a little bit funkier.

Though, I'd love to see a proof of concept that proves me wrong on that.

We have floated the idea of a plugin system in the past, but that would be a future endeavor.

I'll still add the feature request tag since this would make a nice addition!

@gingerchew gingerchew added enhancement feature-request New Feature / Plugin Candidate labels Dec 10, 2022
@jimblue
Copy link
Author

jimblue commented Dec 13, 2022

Hey @gingerchew 🙂
You can probably look at Photoswipe.
It doesn't use any dependency and the lightbox is generated on the fly.

@Andrew-web-coder
Copy link

@jimblue Fancybox v5 also looks great and comes with two types of thumbnails!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature-request New Feature / Plugin Candidate
Projects
None yet
Development

No branches or pull requests

3 participants