Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@clonescope has a race condition with the UI #283

Open
bgribble opened this issue Dec 2, 2016 · 2 comments
Open

@clonescope has a race condition with the UI #283

bgribble opened this issue Dec 2, 2016 · 2 comments
Labels
Milestone

Comments

@bgribble
Copy link
Owner

bgribble commented Dec 2, 2016

Since the fixes in #279 for making onload stuff async, I've been trying to chase down some race conditions around loadbang actions that change the UI... namely, @clonescope which frequently changes the contents of the display and the number of input and output ports.

Right now, doing a [stepseq 8,3] (from the mfp-patches repo) 10 times will give slightly different results. Sometimes not all the output ports show up; sometimes a single step or a single UI element within a step (a dial, for example) are comically misplaced. Sometimes it works fine.

The underlying object in MFP is fine, but the display properties get out of sync.

@bgribble bgribble added the bug label Dec 2, 2016
@bgribble bgribble added this to the mfp 0.06 milestone Dec 2, 2016
@bgribble
Copy link
Owner Author

bgribble commented Dec 6, 2016

The above commit puts a solid nail in the coffin, I think. Basically it implements the policy that the GUI owns "gui_params" and the main process has to explicitly change each value that it wants to change. This reduces the surface for the race condition appreciably. It's still possible that a race could come up -- this is a mirrored-data situation with loose sync and slow update. But I can't reproduce it any more. Closing for now.

@bgribble bgribble closed this as completed Dec 6, 2016
@bgribble
Copy link
Owner Author

bgribble commented Feb 8, 2017

This still shows up in some cases. Particularly the [mix8bus] object... [mix8bus 8] from the [bobtronix] patch will have the second channel (first cloned channel) offset in X and Y by 20 or so pixels.

@bgribble bgribble reopened this Feb 8, 2017
@bgribble bgribble modified the milestones: mfp 0.07, mfp 0.06 Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant