Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bus] objects are named in patch scope, not containing scope #200

Closed
bgribble opened this issue Oct 1, 2014 · 2 comments
Closed

[bus] objects are named in patch scope, not containing scope #200

bgribble opened this issue Oct 1, 2014 · 2 comments
Labels
Milestone

Comments

@bgribble
Copy link
Owner

bgribble commented Oct 1, 2014

Creating a receive-via for a new name causes a [bus] or [bus~] object to be created as well. This is to allow multiple-send, multiple-receive message distribution.

I have observed that creating a receive via within a layer having a non-default scope creates the via itself in the correct (non-default) scope, but the [bus] (and the name associated with the via) are created in the default scope.

This can be seen from the console by calling app.resolve('name', <widget>) where is a widget in the non-default scope (like the via).

@bgribble bgribble added the bug label Oct 1, 2014
@bgribble bgribble added this to the mfp 0.05 milestone Oct 1, 2014
@bgribble
Copy link
Owner Author

bgribble commented Oct 1, 2014

This is an artifact of the load process. If the via is created interactively, the [bus] is in the correct scope. But if the patch is saved and loaded, the via object is initially created in the default scope and then bound to the new scope. The [bus] is not moved because it's not named explicitly in the save file.

bgribble added a commit that referenced this issue Oct 1, 2014
Also, updates to MFPApp.resolve() to better find objects in the context
of a Patch.
@bgribble
Copy link
Owner Author

bgribble commented Oct 1, 2014

With the above commit, this issue is fixed but there's still an issue with changing the scope of a receive-via. If a bus was created , its scope won't change if you just send the @rescope method to the via object. You'd have to do it in the console for now. Created #201 for that work, closing this one.

@bgribble bgribble closed this as completed Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant