New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect next_bit assignment? #9

Open

randyrossi opened this issue Jul 5, 2018 · 1 comment

randyrossi commented Jul 5, 2018

simplisafe-rf/simplisafe/pigpio.py

Line 221 in 266d5e6

next_bit ^= next_bit

Should this be next_bit ^= 1 instead of next_bit ^= next_bit?. The equivalent section in the 'script' version of this method implies it should be.

Owner

bggardner commented Jul 5, 2018

Yes, I believe you're right. However, I no longer have the V2 hardware so I can't test it.

alandtse added a commit to alandtse/simplisafe-rf that referenced this issue


          fix: use fix proposed in bggardner#9

532bbe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment