Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-date browser support #49

Open
akrawchyk opened this issue Oct 25, 2016 · 3 comments
Open

Out-of-date browser support #49

akrawchyk opened this issue Oct 25, 2016 · 3 comments

Comments

@akrawchyk
Copy link

Browser support includes every sane browser and IE7+.

I believe this statement in the README is incorrect. Even in the horsey.es5.js file, the ES6 Symbol is being used without a polyfill. Because of this, among other issues, horsey does not work on any version of IE.

@akrawchyk
Copy link
Author

akrawchyk commented Oct 25, 2016

Also, I believe IE11 is barfing on this throw with error Object expected:

https://github.com/bevacqua/horsey/blob/master/dist/horsey.js#L434

screen shot 2016-10-25 at 4 52 58 pm

try -> catch -> finally -> try -> finally -> throw ( ⧉ ⦣ ⧉ )

@akrawchyk
Copy link
Author

The culprit might be the for (... of ...) loop here

for (let char of text) {
which looks like it's being transformed with babel or something to provide the feature with ES5.

@akrawchyk
Copy link
Author

This also seems to be related babel/babel#4451.

Specifically babel/babel#4451 (comment) which looks similar to the bundled output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant