Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add immutability to nodepools #1385

Merged
merged 13 commits into from
May 14, 2024
Merged

add immutability to nodepools #1385

merged 13 commits into from
May 14, 2024

Conversation

Despire
Copy link
Contributor

@Despire Despire commented May 13, 2024

Closes #1378

@Despire Despire requested a review from JKBGIT1 May 14, 2024 05:35
JKBGIT1
JKBGIT1 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@JKBGIT1 JKBGIT1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions.
Otherwise LGTM 👍

services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
services/claudie-operator/pkg/controller/controller.go Outdated Show resolved Hide resolved
Despire and others added 8 commits May 14, 2024 08:42
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
2e981a8 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
81dcb7b 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
5a540d3 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
7c8ece7 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
98f64c7 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
d01cbb4 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
@Despire @JKBGIT1
Update services/claudie-operator/pkg/controller/controller.go
8f76869 
Co-authored-by: Jakub Hlavačka <jakubhlavacka123@gmail.com>
Auto commit - update kustomization.yaml
41933f6
@Despire Despire added this pull request to the merge queue May 14, 2024
Merged via the queue into master with commit a6836cd May 14, 2024
@Despire Despire deleted the feat/immutability branch May 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKBGIT1 JKBGIT1 JKBGIT1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Immutable Nodepools
2 participants
@Despire @JKBGIT1