Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[caldav] Add sync project in tags #78

Closed
wants to merge 1 commit into from
Closed

[caldav] Add sync project in tags #78

wants to merge 1 commit into from

Conversation

saccarosium
Copy link
Contributor

Description

Add ability to save project into caldav tags by prepending with proj:, allowing creation of project's specific task directly from caldav.

On Nextcloud Task looks like this:

Screenshot 2023-03-08 at 20 15 48

Fixes #73

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Mannually, by creating task from both side and see if they sync correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@saccarosium saccarosium closed this by deleting the head repository Mar 23, 2023
@bergercookie
Copy link
Owner

Hi @saccarosium ,

Sorry for the long wait in answering.
Did you close the PR by accident ? I'm happy to review and get it merged in the next few days.

@saccarosium
Copy link
Contributor Author

Sorry closed for accident!

@saccarosium saccarosium reopened this Mar 24, 2023
bergercookie
bergercookie reviewed Apr 4, 2023
View reviewed changes
Copy link
Owner

@bergercookie bergercookie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!
I still need to give it a go but looks good overall

Could you rebase on top of latest master and address the comments?

readme-tw-caldav.md Show resolved Hide resolved
syncall/tw_caldav_utils.py Show resolved Hide resolved
syncall/tw_caldav_utils.py Show resolved Hide resolved
syncall/tw_caldav_utils.py Show resolved Hide resolved
syncall/tw_caldav_utils.py Show resolved Hide resolved
@saccarosium
Copy link
Contributor Author

I've made the changes but I will open a new PR because for error I've deleted my fork and now GitHub wants to make me do another PR.

@saccarosium saccarosium closed this Apr 4, 2023
@saccarosium saccarosium mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergercookie bergercookie bergercookie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put task in a specific project from caldav side
2 participants
@saccarosium @bergercookie