Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with go install #26

Open
shtirlic opened this issue Oct 14, 2022 · 6 comments
Open

Make compatible with go install #26

shtirlic opened this issue Oct 14, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@shtirlic
Copy link

shtirlic commented Oct 14, 2022

Is it possible to install via

go install github.com/bensadeh/circumflex@latest

now it's error with

go install github.com/bensadeh/circumflex@latest                                                                 1 ↵
go: downloading github.com/bensadeh/circumflex v0.0.0-20221014062858-feb512648702
go: github.com/bensadeh/circumflex@latest: github.com/bensadeh/circumflex@v0.0.0-20221014062858-feb512648702: parsing go.mod:
        module declares its path as: clx
                but was required as: github.com/bensadeh/circumflex
@bensadeh
Copy link
Owner

This is something I'd like to add, but as far as I understand this issue is currently blocking it.

Since clx is the binary name (as opposed to circumflex), go install currently does not offer a way to rename the binary on install.

@bensadeh bensadeh added the enhancement New feature or request label Oct 18, 2022
@krmbzds
Copy link

krmbzds commented Oct 21, 2022

Is it an option to settle with either clx or circumflex as the binary name?

The current instructions to install from source appear to be building and running instead of installing clx. This can be confusing for ones not familiar with golang (like myself). If we wait on golang/go#44469 we might be in for a long long time.

Also, solving this would make it easy for me to install clx using asdf-vm. I use asdf-golang plugin to install go packages. This way I can just add the repo URL to my .default-golang-pkgs file and not have to think about it.

These are mere suggestions so please take them with a grain of salt.

@bensadeh
Copy link
Owner

I am not sure what you mean by settle on either clx or circumflex as the binary name. clx is the binary name for running circumflex (same as rg is the binary name for running ripgrep).

I agree that the installation instructions are a bit confusing for running from source, I will update it to use go install locally, which will put the clx binary in $GOPATH/bin.

@bensadeh
Copy link
Owner

I've posted and pinned #37 which I hope can be a good workaround for users looking for simple ways to install circumflex until we can use go install.

@krmbzds
Copy link

krmbzds commented Oct 22, 2022

Thanks for updating the instructions 5c4176c. It's less confusing now. I installed circumflex using go install from source and clx is in my path. 👍

@bensadeh
Copy link
Owner

@krmbzds Great! :)

Hope in the future that installing circumlex will be easier and simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants