New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kill switch timing testable without sleeps #29

Open

holsee opened this issue Jul 5, 2019 · 1 comment

Labels

Member

holsee commented Jul 5, 2019

Refactor kill_switch function into own module to allow time-based unit testing without Proces.sleep call.

holsee added the enhancement label

Member Author

holsee commented Jul 5, 2019

From the discussions which took place at the Tuesday 2nd July Meet-up:

We need to refactor the kill switch mechanism into its own module
We need a means by which this dependency can be passed into the Service process
A test version of the kill-switch needs to be created that will allow for introspection of the timeout value passed into it, as well as a means to manually trigger the kill switch signal.

holsee mentioned this issue

Added configurable service timeout #25

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment