Add Module Name to JGroups

[eitan-rosenberg]

Now days people are using modules.

So please have a look at this article:
http://branchandbound.net/blog/java/2017/12/automatic-module-name/

From the article:
"This post explains the first step you can take as a library maintainer on your way to becoming a Java module. This first step boils down to picking a module name, and adding it as Automatic-Module-Name: -module name- entry to the library's MANIFEST.MF. That's it".

Regards.

[belaban]

So I added this to the POM:

---

<manifestEntries>
       <Automatic-Module-Name>org.jgroups</Automatic-Module-Name>
</manifestEntries>

Good?

[eitan-rosenberg]

Good morning,

The end result is something like this ( from Apache Commons IO commons-io-2.11.0.jar ) :

If you want me to test is before you commit then send me a link please.

Thanks.

[belaban]

I already committed this, the result is what you pasted above: Automatic-Module-Name: org.jgroups

[eitan-rosenberg]

Ok, I will test it now.

[eitan-rosenberg]

The latest in maven is 5.2.10.Final

[tristantarrant]

You need to build from source

[eitan-rosenberg]

Thanks,
I will wait until the next Maven update.
Regards.

[belaban]

That will take a while... If you build a snapshot JAR locally and test, and there's still an issue, the fix (to be fixed later) will be in 5.2.11. If you wait for 5.2.11, and the issue still persists, then the fix will be in 5.2.12 only...

[eitan-rosenberg]

Ok,
Thanks.

[eitan-rosenberg]

Good morning,
The addition of : "Automatic-Module-Name: org.jgroups" seems to work, thank you.
Regards and Happy new year

[belaban]

Same to you, too!