byteman-bmunit.jar after upgrade to 5.2.9

[leonchen83]

        <!-- Test dependencies -->
        <dependency>
            <groupId>org.testng</groupId>
            <artifactId>testng</artifactId>
            <version>6.14.3</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>org.jboss.byteman</groupId>
            <artifactId>byteman-bmunit</artifactId>
            <version>4.0.20</version>
            <scope>compile</scope>
        </dependency>
        <dependency>
            <groupId>org.wildfly.security</groupId>
            <artifactId>wildfly-elytron</artifactId>
            <version>2.0.0.Final</version>
            <scope>test</scope>
        </dependency>

when we upgrade to jgroups 5.2.9. after deployed we found an extra jar byteman-bmunit. should this jar's scope change to <scope>test</scope>?

[rhusar]

Looking at the dependency tree

[rhusar@ribera jgroups]$  mvn dependency:tree -Dscope=compile
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO]   ... total of 1 executions of maven-deploy-plugin replaced with nexus-staging-maven-plugin
[WARNING] The project org.jgroups:jgroups:jar:5.2.10.Final-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[INFO]
[INFO] ------------------------< org.jgroups:jgroups >-------------------------
[INFO] Building JGroups 5.2.10.Final-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.3.0:tree (default-cli) @ jgroups ---
[INFO] org.jgroups:jgroups:jar:5.2.10.Final-SNAPSHOT
[INFO] +- org.apache.logging.log4j:log4j-core:jar:2.19.0:compile
[INFO] +- org.apache.logging.log4j:log4j-api:jar:2.19.0:compile
[INFO] +- org.slf4j:slf4j-api:jar:2.0.3:compile
[INFO] \- org.jboss.byteman:byteman-bmunit:jar:4.0.20:compile
[INFO]    +- org.jboss.byteman:byteman:jar:4.0.20:compile
[INFO]    +- org.jboss.byteman:byteman-submit:jar:4.0.20:compile
[INFO]    \- org.jboss.byteman:byteman-install:jar:4.0.20:compile

that's clearly wrong.

[rhusar]

Opened #681 with the fix.

[rhusar]

There might be more to it, let's discuss on the PR - atm it's really a compile time dependecy as that class using it is in the main jgroups jar

[belaban]

The reason I made this compile is https://issues.redhat.com/browse/JGRP-2640: I need to ship a JAR that contains prot-perf.btm, ProtPerfHelper and the jgroups-perf.sh script. @rhusar I'm sure there are better ways to do this, ideas?

[belaban]

I reverted the PR and made byteman-bmunit.jar a compile dep (for now, until we know how to fix this)