Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bower to node dependencies? #33

Open
brazorf opened this issue Sep 17, 2017 · 1 comment
Open

Add bower to node dependencies? #33

brazorf opened this issue Sep 17, 2017 · 1 comment

Comments

@brazorf
Copy link

brazorf commented Sep 17, 2017

I just had to install bower myself while in the process of installing locally.

I think thats confusing to non-dev end users, since if they run npm install + bower install they are gonna get an error on the latter.

Why not adding bower in package.json?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@SpikedPunchVictim
Copy link

SpikedPunchVictim commented Jan 18, 2018

For anyone else attempting to host this themselves, you'll need to modify the package.json file:

{
  "author": "Renato de Pontes Pereira",
  "name": "behavior3editor",
  "version": "0.3.0",
  "homepage": "http://behavior3.com",
  "license": "MIT",
  "bugs": "https://github.com/behavior3/behavior3editor/issues",
  "repository": "github:behavior3/behavior3editor",
  "scripts": {
    "build": "gulp build",
    "serve": "gulp serve",
    "postinstall": "bower install"
  },
  "devDependencies": {
    "bower": "^1.8.2",
    "electron-packager": "^5.1.1",
    "electron-prebuilt": "^0.33.8",
    "gulp": "~3.9.0",
    "gulp-angular-templatecache": "~1.7.0",
    "gulp-concat": "~2.6.0",
    "gulp-connect": "~2.2.0",
    "gulp-foreach": "^0.1.0",
    "gulp-jshint": "~1.11.2",
    "gulp-less": "~3.0.3",
    "gulp-minify-css": "~1.2.1",
    "gulp-minify-html": "~1.0.4",
    "gulp-replace": "~0.5.4",
    "gulp-uglify": "~1.4.1",
    "gulp-zip": "^3.0.2",
    "jshint-stylish": "~2.0.1",
    "merge-stream": "~1.0.0",
    "rimraf": "^2.4.3"
  },
  "dependencies": {}
}

The modifications added:

  • The bower dependency
  • The postinstall, build, & serve scripts

Run:

  • npm install
  • npm run build
  • npm run serve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants