fetchart plugin does not import cover art when import is run with move and quiet enabled
#5167
Comments
mgoltzsche
added a commit
to mgoltzsche/beets-ytimport
that referenced
this issue
Mar 29, 2024
Though, unfortunately the cover art file is not imported in quiet mode, see beetbox/beets#5167
|
It has nothing to do with move or quite group_albums: yesis the culprit. well not culprit exactly because group albums does not care about folders, it is meant to be used when multiple tracks from different albums is in the same folder, and when you use that you are telling beets to group based on albums and not folder, so any images are ignored in the process. set that to no and it will "move quitely" as expected. |
mgoltzsche
added a commit
to mgoltzsche/beets-ytimport
that referenced
this issue
May 12, 2024
...by not grouping by albums when importing album/collection folders. See beetbox/beets#5167
|
Ah, thanks @Dr-Blank for clarifying that. I misinterpreted the option. Disabling it makes beets import the |
mgoltzsche
added a commit
to mgoltzsche/beets-ytimport
that referenced
this issue
May 12, 2024
To avoid leaving album directories within the ytimport directory, each containing only a `cover.jpg` file. See beetbox/beets#5167
|
However, in case of the ytimport plugin, unfortunately the UPDATE: This is addressed by PR #5244. |
mgoltzsche
added a commit
to mgoltzsche/beets-ytimport
that referenced
this issue
May 13, 2024
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source file removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
3 tasks
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source file removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of only evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source file removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of only evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
mgoltzsche
added a commit
to mgoltzsche/beets
that referenced
this issue
May 13, 2024
Defer the evaluation of the source file removal options (`import.delete` and `import.move`) to the point where the fetchart plugin is actually called instead of only evaluating those configuration options on plugin initialization. This is to allow other plugins (such as the [ytimport](https://github.com/mgoltzsche/beets-ytimport/blob/v1.8.1/beetsplug/ytimport/__init__.py#L194) plugin) to invoke the import directly (within the same python process; implicitly invoking the fetchart plugin) with temporarily overwritten configuration options. Relates to beetbox#5167 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I import a directory that includes a
cover.jpgfile into my beets library with bothimport.moveandimport.quietset totrue, the cover art is not imported.When I disable
moveorquiet, it imports the cover art.(However, when importing the cover art, the fetchart plugin does not use the
cover.jpgthat exists within the album source directory but fetches it from coverartarchive.org. Correspondingly, thecover.jpgfile within the import source directory is not deleted after the import althoughmoveis enabled.)Problem
Imagine I have the import options
group_albums,moveandquietenabled and the following file system structure to import from:/data/ytimport/albums/some artist - some album01 - First Track.opus02 - Second Track.opuscover.jpgRunning this command in verbose (
-vv) mode:Does not import any cover art.
The log shows that the
fetchartplugin tries to lookup the cover art within the file system and that it doesn't try the other cover art sources:When I disable any of the
import.moveorimport.quietconfiguration options, it imports cover art - from a non-filesystem source, though.You can get the example data e.g. using the ytimport plugin:
beet ytimport --no-import https://www.youtube.com/watch?v=4D8YPDdsxYUSetup
--plugins=fetchartMy configuration (output of
beet config) is:The text was updated successfully, but these errors were encountered: