Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit buttons #2

Open
ayushi-agrawal-gladstone opened this issue Dec 14, 2022 · 1 comment
Open

Edit buttons #2

ayushi-agrawal-gladstone opened this issue Dec 14, 2022 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@ayushi-agrawal-gladstone
Copy link
Collaborator

ayushi-agrawal-gladstone commented Dec 14, 2022

Hi @AlexanderPico ,

The website looks great. 

In the screenshot below, the edit buttons (highlighted by red arrows) take one to the GitHub .md file for that page. I forget, will the edit buttons be visible and work only for those who are added to the GitHub repo for Occident?  Or are the edit buttons available to everyone who can access the website? I tried clicking the edit buttons in the incognito browser and it asks me to log into GitHub. So, if edit buttons are for everyone, we might need to explicitly mention that one needs to have a GitHub account to be able to use the edit buttons.

Best,
Ayushi

occident_edit_buttons

@AlexanderPico
Copy link
Collaborator

AlexanderPico commented Dec 14, 2022

Right. A GitHub account is required to either edit the file directly or produce a PR.

I do not know if they want this feature or for whom they want it to work. It's an internal editing tool for now and a demo of a potential public feature.

@AlexanderPico AlexanderPico added the question Further information is requested label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants