Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 issues #21

Open
mobri2a opened this issue Mar 23, 2024 · 0 comments
Open

Python 2.7 issues #21

mobri2a opened this issue Mar 23, 2024 · 0 comments

Comments

@mobri2a
Copy link

mobri2a commented Mar 23, 2024

Python 2.7 is EOL and becoming harder to support for old apps. I was unable to get install.sh to work with the "default" klippy-env at all - it was impossible to get scipy to install under Python 2.7.

You should recommend to users that they upgrade to Python 3 (use a tool like kaiuh or simply remove klippy-env and replace it using virtualenv). Alternatively, provide instructions to users on where to get a version of numpy and scipy that will work with Python 2.7 (I was unable to find one).

The second change is the install.sh for the beacon. Source the activate script to activate the virtual enviroment, then use pip without the full path to update the environment. The current implementation is terribly hard to work with and likely to cause problems (regardless of whether it ever happened to work).

Ex.

KDIR="${HOME}/klipper"
KENV="${HOME}/klippy-env"
. ${KENV}/bin/activate
...
# install beacon requirements to env
echo "beacon: installing python requirements to env, this may take 10+ minutes."
"pip" install -r "${BKDIR}/requirements.txt"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant