Improve text alignment #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brittanychiang ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@bchiang7 can we get this merged please |
|
The text alignment in the featured project section was a design choice on my part, so I'm going to keep it that way. If you wish to deal with text orphans in your own project, feel free! |
|
I understand it from a design perspective and I think it looks nice on single line text but I believe that this design doesn't have the desired effect on multiline paragraphs. From a UX perspective, I think this actually has a negative effect because paragraphs are meant to be read from left to right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220