From 5238af63c171633fa07bc6c15e4c55ee03f3a830 Mon Sep 17 00:00:00 2001 From: Vladimir Rodkin Date: Wed, 16 Mar 2016 21:27:20 +0300 Subject: [PATCH] fix: Add button type #33 --- src/imageCropper.js | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/src/imageCropper.js b/src/imageCropper.js index b6a1045..2f59fd0 100644 --- a/src/imageCropper.js +++ b/src/imageCropper.js @@ -187,19 +187,13 @@ Cropper.prototype.buildDOM = function() { _elements.controls.wrapper = document.createElement('div'); _elements.controls.wrapper.className = 'imgCropper-controls'; - _elements.controls.rotateLeft = document.createElement('button'); - _elements.controls.rotateLeft.innerHTML = this.options.actionLabels.rotateLeft; - _elements.controls.rotateRight = document.createElement('button'); - _elements.controls.rotateRight.innerHTML = this.options.actionLabels.rotateRight; - _elements.controls.zoomIn = document.createElement('button'); - _elements.controls.zoomIn.innerHTML = this.options.actionLabels.zoomIn; - _elements.controls.zoomOut = document.createElement('button'); - _elements.controls.zoomOut.innerHTML = this.options.actionLabels.zoomOut; - _elements.controls.fit = document.createElement('button'); - _elements.controls.fit.innerHTML = this.options.actionLabels.fit; - - _elements.controls.crop = document.createElement('button'); - _elements.controls.crop.innerHTML = this.options.actionLabels.crop; + _elements.controls.rotateLeft = this._buildControl(this.options.actionLabels.rotateLeft); + _elements.controls.rotateRight = this._buildControl(this.options.actionLabels.rotateRight); + _elements.controls.zoomIn = this._buildControl(this.options.actionLabels.zoomIn); + _elements.controls.zoomOut = this._buildControl(this.options.actionLabels.zoomOut); + _elements.controls.fit = this._buildControl(this.options.actionLabels.fit); + + _elements.controls.crop = this._buildControl(this.options.actionLabels.crop); // Target -> Wrapper -> buttons _elements.controls.wrapper.appendChild(_elements.controls.rotateLeft); @@ -213,6 +207,19 @@ Cropper.prototype.buildDOM = function() { this.loadImage(); }; +/** + * Build control element. + * @param label + * @returns {Element} + */ +Cropper.prototype._buildControl = function(label) { + var control = document.createElement('button'); + control.setAttribute('type', 'button'); + control.innerHTML = label; + + return control; +}; + /** * Remove all DOM element parts of the Cropper. */