Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Add default DKIM configuration to MailerBuilder and performance improvement #196

Open
bbottema opened this issue Feb 5, 2019 · 1 comment
Open

Performance: Add default DKIM configuration to MailerBuilder and performance improvement #196

bbottema opened this issue Feb 5, 2019 · 1 comment
Labels
enhancement Priority-Low

Comments

@bbottema
Copy link
Owner

bbottema commented Feb 5, 2019

There's something to be said for avoiding a performance hit by moving the DKIM construction to the MailerBuilder so this is done only once rather than for each separate email.

Original suggestion by @koen-serry
@bbottema bbottema added this to the 6.0.1 milestone Oct 12, 2019
@bbottema bbottema modified the milestones: 6.0.1, 6.1.0 Mar 20, 2020
@bbottema bbottema modified the milestones: 6.2.0, 6.x.0 Jul 10, 2020
@bbottema bbottema mentioned this issue May 31, 2021
Closed
@bbottema
Copy link
Owner Author

bbottema commented Jun 1, 2021

I've refactored the library a little bit so that there now is a special config group on the Mailer level. Email validation criteria moved there and I've added default S/MIME signing in there as well. Next step would be to finally add default DKIM signing in there as well. Will work on this soon.

@bbottema bbottema changed the title Consider moving the DKIM configuration from EmailBuilder to MailerBuilder Add default DKIM configuration to MailerBuilder and performance improvement Jun 1, 2021
@bbottema bbottema modified the milestones: 6.x.0, 7.0.0 Jun 12, 2021
@bbottema bbottema added this to To do in 7.0.0 Jun 12, 2021
@bbottema bbottema removed this from To do in 7.0.0 Jan 2, 2022
@bbottema bbottema removed this from the 7.0.0 milestone Jan 2, 2022
@bbottema bbottema changed the title Add default DKIM configuration to MailerBuilder and performance improvement Performance: Add default DKIM configuration to MailerBuilder and performance improvement Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Priority-Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbottema