Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test failure on FIX for AMP ads tests - unhandled promise rejection #9178

Open
2 tasks
jroebu14 opened this issue Jun 11, 2021 · 1 comment · Fixed by #9457
Open
2 tasks

Cypress test failure on FIX for AMP ads tests - unhandled promise rejection #9178

jroebu14 opened this issue Jun 11, 2021 · 1 comment · Fixed by #9457
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) cypress Cypress changes are required technical-work Technical debt, support work and building new technical tools and features

Comments

@jroebu14
Copy link
Contributor

jroebu14 commented Jun 11, 2021

Describe the bug
Cypress v7 introduced a new feature that fails tests when the test runner detects any unhandled promise rejections. This is failing AMP ads tests for FIX pages.

Screenshot 2021-06-11 at 11 20 57

To move forward with the Cypress v7 upgrade, we have decided to disable tests failing on unhandled promise rejections and revisit this error when we have more time to.

To Reproduce
Steps to reproduce the behaviour:

  1. Remove these lines of code
  2. Run Cypress
  3. Observe failing featureIndexPage tests

Expected behaviour
There should be no unhandled promise rejections.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Testing notes

  • This bug fix is expected to need manual testing.

Checklist

Additional context
Add any other context about the problem here.

@jroebu14 jroebu14 added the bug Something isn't working label Jun 11, 2021
@jroebu14 jroebu14 added this to Coming Soon in Simorgh via automation Jun 11, 2021
@jroebu14 jroebu14 added cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features labels Jun 11, 2021
@pvaliani pvaliani added the cypress Cypress changes are required label Aug 3, 2021
@amoore108 amoore108 self-assigned this Sep 27, 2021
@amoore108 amoore108 moved this from Coming Soon to Issue in Progress [WIP 12] in Simorgh Sep 27, 2021
Simorgh automation moved this from Issue in Progress [WIP 12] to Done Sep 28, 2021
@amoore108 amoore108 removed this from Done in Simorgh Oct 7, 2021
@amoore108
Copy link
Contributor

Reopening this as the previous attempt to remove the promise exception handler seems to have introduced E2E failures on Test/Live in CodePipeline, see issue #9465.

I can't narrow down the errors being reported in #9465 locally. I've tried running the test suites in local, test and live with various combinations of the CYPRESS_ flags, but to avail, they all complete and pass as expected. The tests on CodePipeline aren't consistently failing either, which compounds the issue of debugging further.

Latest PR for reverting #9457
#9521

@amoore108 amoore108 reopened this Oct 7, 2021
@amoore108 amoore108 removed their assignment Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) cypress Cypress changes are required technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants