New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Starlark Transition Composition #22248
Labels
P1
I'll work on this now. (Assignee required)
team-Configurability
Issues for Configurability team
type: feature request
Comments
katre
added
type: feature request
P1
I'll work on this now. (Assignee required)
team-Configurability
Issues for Configurability team
labels
May 6, 2024
copybara-service bot
pushed a commit
that referenced
this issue
May 7, 2024
Part of #22248. PiperOrigin-RevId: 631416237 Change-Id: I91d40ad30673ee352624a1580a23de3855a28bd0
copybara-service bot
pushed a commit
that referenced
this issue
May 7, 2024
…ble. (This was accidentally broken with no tests by a pending change). Part of #22248. PiperOrigin-RevId: 631447201 Change-Id: Ie099705b35aff672efe0ee71b26d28aca2836a4f
copybara-service bot
pushed a commit
that referenced
this issue
May 9, 2024
Also split StarlarkRuleClassTests into its own target. Part of #22248. PiperOrigin-RevId: 632182116 Change-Id: Ia6dcf68f45d1fd8b48026ee94c827bdc9ad992ce
copybara-service bot
pushed a commit
that referenced
this issue
May 9, 2024
Part of #22248. PiperOrigin-RevId: 632193752 Change-Id: Ic41afbc4ec508ad08615a8861278d5593bb73849
copybara-service bot
pushed a commit
that referenced
this issue
May 10, 2024
This guarantees that it is accurate, the default of `ANY` was too broad. Part of #22248. PiperOrigin-RevId: 632513554 Change-Id: I90b66b45b640ba84b658f23cb56a9016dd853310
copybara-service bot
pushed a commit
that referenced
this issue
May 10, 2024
…itions. Part of #22248. PiperOrigin-RevId: 632514548 Change-Id: I3a0864e3fd11d318e33b10be9367dd51c383d599
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
Part of bazelbuild#22248. PiperOrigin-RevId: 631416237 Change-Id: I91d40ad30673ee352624a1580a23de3855a28bd0
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
…ble. (This was accidentally broken with no tests by a pending change). Part of bazelbuild#22248. PiperOrigin-RevId: 631447201 Change-Id: Ie099705b35aff672efe0ee71b26d28aca2836a4f
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
Also split StarlarkRuleClassTests into its own target. Part of bazelbuild#22248. PiperOrigin-RevId: 632182116 Change-Id: Ia6dcf68f45d1fd8b48026ee94c827bdc9ad992ce
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
Part of bazelbuild#22248. PiperOrigin-RevId: 632193752 Change-Id: Ic41afbc4ec508ad08615a8861278d5593bb73849
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
This guarantees that it is accurate, the default of `ANY` was too broad. Part of bazelbuild#22248. PiperOrigin-RevId: 632513554 Change-Id: I90b66b45b640ba84b658f23cb56a9016dd853310
Kila2
pushed a commit
to Kila2/bazel
that referenced
this issue
May 13, 2024
…itions. Part of bazelbuild#22248. PiperOrigin-RevId: 632514548 Change-Id: I3a0864e3fd11d318e33b10be9367dd51c383d599
copybara-service bot
pushed a commit
that referenced
this issue
May 13, 2024
…lark should implement ConfigurationTransitionApi. StarlarkExposedRuleTransitionFactory is clarified, and is not itself exposed to Starlark. Part of #22248. PiperOrigin-RevId: 633199947 Change-Id: I19032aaf6b4db1ae5c496077495a01f8b6c4d0b0
copybara-service bot
pushed a commit
that referenced
this issue
May 13, 2024
Part of #22248. PiperOrigin-RevId: 633201757 Change-Id: I4b1127358eabcd3438eaa8adde9a48d55efb6394
copybara-service bot
pushed a commit
that referenced
this issue
May 14, 2024
This is the same transition as `cfg = "target"`. RELNOTES: A no-op transition is now available as `config.target()`. Part of #22248. PiperOrigin-RevId: 633665060 Change-Id: I63f81d1378b6af7ed4fb4b81ea1df3db9de526ad
copybara-service bot
pushed a commit
that referenced
this issue
May 22, 2024
Work towards composable starlark transitions: #22248. PiperOrigin-RevId: 636209749 Change-Id: I9ecdec8b376a9c95b06dea36bacbf9268d0c5195
copybara-service bot
pushed a commit
that referenced
this issue
May 22, 2024
This helps to reduce dependency cycles. Work towards composable starlark transitions: #22248. PiperOrigin-RevId: 636260650 Change-Id: I17c0137e9d442fb02cf51e360ede876b4d92f6c4
copybara-service bot
pushed a commit
that referenced
this issue
May 23, 2024
Part of entirely removing TransitionFactories: we should directly create and use factories everywhere. Future changes will continue with this theme. Work towards composable starlark transitions: #22248. PiperOrigin-RevId: 636641944 Change-Id: Ib345da940cb78867484411b4abda4f8d55cb2ba2
copybara-service bot
pushed a commit
that referenced
this issue
May 23, 2024
Work towards composable starlark transitions: #22248. PiperOrigin-RevId: 636644277 Change-Id: I08bd0d006e5d68f195bc4bada1c782982fc70528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P1
I'll work on this now. (Assignee required)
team-Configurability
Issues for Configurability team
type: feature request
Tracking issue for implementation of https://github.com/bazelbuild/proposals/blob/main/designs/2024-04-16-transition-composition.md.
The text was updated successfully, but these errors were encountered: