Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with the sequential domain reduction #476

Open
bwkong opened this issue May 10, 2024 · 1 comment
Open

Bug with the sequential domain reduction #476

bwkong opened this issue May 10, 2024 · 1 comment

Comments

@bwkong
Copy link

bwkong commented May 10, 2024

Bug1
In domain_reduction.py, line 105-108:
for i, entry in enumerate(new_bounds):
if entry[0] > entry[1]:
new_bounds[i, 0] = entry[1]
new_bounds[i, 1] = entry[0]
I guess it aims to swap the values of two entries but it does not work in that way. When new_bounds[i, 0] is rewritten, entry[0] will also be rewritten and new_bounds[i, 1] cannot be designated the appropriate value.

Bug2
new_bounds in the function transform in domain_reduction.py is never trimmed:
line 147: self._trim(new_bounds, self.original_bounds) is doing nothing.
Instead, it should be like: new_bounds = self._trim(new_bounds, self.original_bounds)
These have caused new bounds not within the original bounds.

@till-m
Copy link
Member

till-m commented May 11, 2024

Hey @bwkong,

thanks for reporting this bug. I think this might be fixed already via #441. We have just not pushed a release since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants