What do you want in the next major version?

[rez1dent3]

There is already too much implemented in the wallet. Tell me what you would like to see inside the package?

[pourmami]

I would like to show withdraw and deposits history for each user separately. is it possible now? I don't see anything related in the docs

[rez1dent3]

It can be done now. I'll make an example for you later.

[rez1dent3]

If you want to withdraw transactions for all user wallets:

$user->transactions()

If you want to withdraw transactions from the default wallet:

$user->walletTransactions()

If you use multi-wallets and need to withdraw transactions for a specific wallet:

$wallet->walletTransactions()

How to choose a specific wallet? https://bavix.github.io/laravel-wallet/#/new-wallet?id=how-to-get-the-right-wallet

[pourmami]

Thank you ♥

[DevMau00]

Native DB support for swap currency values, instead of having to load them thru service providers. 😁

[rez1dent3]

Please write your idea in more detail. Thank you.

If I understand you correctly, are you talking about replacing laravel-wallet-swap with a table inside a package that will already be filled somehow? Only the swap package is a common solution for everyone and its response is easily cached for the required time in any database.

[DevMau00]

The DB was just one way to work with the rates thru the controller, like if you want to fetch a rate from a previous rate you have on another table. Or another instance, if you get dynamic currency exchange rates from an external API from an user input on the front, and then needed to pass that value into the User thru a relationship so you could set the exchange first in the provider, and then on the controller you would need to make the deposit so the transaction could be created, yes?.

It would be awesome if you could set the rate at which the transaction its going to be exchanged from there. Skipping the step of setting the rate in the service provider first.

If there are any questions or if I didn't explain myself correctly let me know, so I can elaborate. Eng is not my main lang.

[DevMau00]

Something like:

// origin wallet / destination wallet / amount to exchange
$user->exchange(['USD' => 1.11],['EUR' => 0.91],100);
//result 91 EUR

Just an example. Dunno if it's dumb tho. Maybe theres already a way to do this and I'm just implementing it wrong. 😅

[rez1dent3]

Nowadays, you can’t manually specify a currency rate for a transaction (exchange), but you can fill it in globally or implement your custom service provider.

An example implementation of a service provider can be found here:
https://github.com/bavix/laravel-wallet-swap/blob/7109f1a2a5d947b1dc87ef9c49897cc2ff44d7ae/src/SwapExchangeService.php#L36

laravel-wallet-swap uses the florianv/laravel-swap library, and it can already be configured as you please. You can fill it through arrays, you can use API, or you can take data from tables.

Example via array:
https://github.com/bavix/laravel-wallet-swap/blob/7109f1a2a5d947b1dc87ef9c49897cc2ff44d7ae/tests/TestCase.php#L44

You can write a custom provider for the library and fill it from the database.

But perhaps I misunderstood you.

[rez1dent3]

#809

[rez1dent3]

add more events #819

[rez1dent3]

Documentation needs to be expanded #818

[rez1dent3]

#824

[gkmk]

@rez1dent3 is currency promotion in this update? I believe this to be something quite useful.

The issue currently is that when listing Transfers (for reports or pagination), in order the get the actual amount and currency you need to load 2 more relationships (Transfer->Transaction->Wallet). My current solution is to extend the default models by adding these attributes inside transfer and transaction.

I know its kind of possible to update the Meta on transaction to keep this info but it makes indexing and querying a bit more difficult and it still requires the Transfer->Transaction relationship.

Am I using the package wrong or is this valid point?

[rez1dent3]

Hello. To be honest, I don't quite understand the context. Could you give an example of what you want to see and why.

[gkmk]

I want to build reports where i list all the transfers for one wallet.

What i have to do currently to access the Amount and Currency i need to do

Number::currency($transfer->deposit->amount, $transfer->from->currency)

What i would like to do is avoid loading relationships and do this

Number::currency($transfer->amount, $transfer->currency)

This is especially helpful when aggregating data as i think the Transfer model is the one that holds the most relevant data to display to the end customer.

Even maybe restructuring the Transfer model attributes
Renaming status into type and status_last into type_last
And introducing new status attribute which would hold ENUM of something like confirmed in transactions.
The status ENUM would be something like pending, confirmed, canceled, failed

[rez1dent3]

Just an hour ago I added extra in a future version. Perhaps this will solve your problem.

#865

My proposal is this. All necessary data can be put into the new extra field and selected without additional queries. Yes, this raises the issue of data consistency, but this can also be solved, it seems to me.