Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation is for v 0.2 but no release #21

Open
chrisjowen opened this issue Feb 24, 2016 · 2 comments
Open

documentation is for v 0.2 but no release #21

chrisjowen opened this issue Feb 24, 2016 · 2 comments

Comments

@chrisjowen
Copy link

chrisjowen commented Feb 24, 2016

Hi,

I followed your documentation and the version you specify (i.e. 0.1) creates a different method signature for Blacksmith.save whereby it expects a repo as the first argument. So your example was failing for me:

user = Forge.saved_user name: "Will Override", favorite_language: "Elixir"

I noticed that the signature changed in the master branch so I am using this, but it would be helpful to either change the documentation or push another release.

Cheers, Chris

@seanabrahams
Copy link

seanabrahams commented May 12, 2016

@batate @ericmj Please mix hex.publish. It only takes a second and saves us users from spending potentially a lot of time figuring out what's wrong. Thanks for the library!

@paulgoetze
Copy link

paulgoetze commented Jun 30, 2016

It might also make sense to have release tags here in this Repo, so that you can easily spot the current version. Also a changelog (either as file or in release tag notes) would be great to prevent such situations. (Of cause then release tags and hex releases should still be kept in sync.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants