Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riak 3.x riak chkconfig command returns non-zero on success #1125

Open
tburghart opened this issue Jan 24, 2023 · 0 comments
Open

riak 3.x riak chkconfig command returns non-zero on success #1125

tburghart opened this issue Jan 24, 2023 · 0 comments
Assignees

Comments

@tburghart
Copy link
Contributor

tburghart commented Jan 24, 2023

Per the relx extension script contract, extension scripts should exit with an appropriate result code.

riak/rel/files/riak-chkconfig does not do this (the two other extension scripts do), and therefore picks up the non-zero exit provided by the relx-generated bin/riak script.

The solution is to add the following (or something like it) to the end of the rel/files/riak-chkconfig file:

--- a/rel/files/riak-chkconfig
+++ b/rel/files/riak-chkconfig
@@ ...

 echo $CUTTLE_CONF
+
+# No explicit exit from within script or tools, assumed to have succeeded.
+exit 0
@martinsumner martinsumner self-assigned this Jan 24, 2023
martinsumner added a commit that referenced this issue Jan 30, 2023
martinsumner added a commit that referenced this issue Feb 4, 2023
* planned combination for 3.0.13

basho/eleveldb#269 to be added once issues are resolved

* Release preparation - 3.0.13

* For testing of fix to KV1847

* Update with reference to conditional PUT changes

* Update riak-chkconfig

As per #1125

* Update following merge

* Tags for release
martinsumner added a commit that referenced this issue Feb 7, 2023
* planned combination for 3.0.13

basho/eleveldb#269 to be added once issues are resolved

* Release preparation - 3.0.13

* For testing of fix to KV1847

* Update with reference to conditional PUT changes

* Update riak-chkconfig

As per #1125

* Update following merge

* Tags for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants